From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A08C433E6 for ; Mon, 8 Feb 2021 18:18:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A28764E84 for ; Mon, 8 Feb 2021 18:18:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234021AbhBHSSf (ORCPT ); Mon, 8 Feb 2021 13:18:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:52654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235572AbhBHSR4 (ORCPT ); Mon, 8 Feb 2021 13:17:56 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id ABFF860232; Mon, 8 Feb 2021 18:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612808236; bh=qsSUINw5d0ZIbqSO/YSUJD36GYqCRNUaAbAJxQ0z3w0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QJk0JGu/Y/A852FWTAXArleghZ1hdLOUpTtnAU5eEBvyHF3pkax7iYY9oy1imY5Qe YQAxA9xvdys7+6mw/6WIohjRsX7VkTtutGpvFEPmWuw/ETOKPjDu+s2o2SRf8tKlnX igB0n1GFalZwSSZRIqEl6Y6fJbkKMDrjAknWn0jqITAvyNdZ8ji7dQb2MhS9whDNg2 RPXS2CQNK5wTlu30/hP6Z4leOzvD+yySHVbi2iQuegc2mO5iHMSYraEESE9tRDNJy0 igDSofK4N3fHFKf2z+Nbo1J8Wy0e1WIa9v+anqO7b437I7Fac85/EhqH++0AvatxkG 640CqT2fY4+4Q== Date: Mon, 8 Feb 2021 13:17:14 -0500 From: Sasha Levin To: Sedat Dilek Cc: linux-kbuild@vger.kernel.org, Masahiro Yamada Subject: Re: [PATCH] kbuild: simplify access to the kernel's version Message-ID: <20210208181714.GZ4035784@sasha-vm> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Mon, Feb 08, 2021 at 04:28:00AM +0100, Sedat Dilek wrote: >[ Please CC me directly ] > >Hi Sasha, > >I like that patch from [1]. > >What was the Linux-source base? > >Searching in Linux v5.11-rc7: > >$ git grep -E 'LINUX_VERSION_CODE >> (16|8)' >drivers/net/ethernet/mellanox/mlx5/core/main.c: >(u8)((LINUX_VERSION_CODE >> 16) & 0xff), (u8)((LINUX_VERSION_CODE >> >8) & 0xff), >drivers/scsi/gdth.c: osv.version = (u8)(LINUX_VERSION_CODE >> 16); >drivers/scsi/gdth.c: osv.subversion = (u8)(LINUX_VERSION_CODE >> 8); >drivers/usb/core/hcd.c:#define KERNEL_REL >bin2bcd(((LINUX_VERSION_CODE >> 16) & 0x0ff)) >drivers/usb/core/hcd.c:#define KERNEL_VER >bin2bcd(((LINUX_VERSION_CODE >> 8) & 0x0ff)) >drivers/usb/gadget/udc/aspeed-vhub/hub.c:#define KERNEL_REL >bin2bcd(((LINUX_VERSION_CODE >> 16) & 0x0ff)) >drivers/usb/gadget/udc/aspeed-vhub/hub.c:#define KERNEL_VER >bin2bcd(((LINUX_VERSION_CODE >> 8) & 0x0ff)) >include/linux/usb/composite.h: bcdDevice = >bin2bcd((LINUX_VERSION_CODE >> 16 & 0xff)) << 8; >include/linux/usb/composite.h: bcdDevice |= >bin2bcd((LINUX_VERSION_CODE >> 8 & 0xff)); >kernel/sys.c: v = ((LINUX_VERSION_CODE >> 8) & 0xff) + 60; > >So, drivers/scsi/gdth.c file is missing in your list of file: Right. It's on it's way out: 0653c358d2dc ("scsi: Drop gdth driver"). In theory I should have fixed it too, but given that this patch is cosmetic I just wanted to avoid unnecessary conflicts for SFR... If it doesn't end up being removed we can always fix it up there. -- Thanks, Sasha