From: Lecopzer Chen <lecopzer.chen@mediatek.com>
To: <keescook@chromium.org>, <samitolvanen@google.com>,
<linux-kbuild@vger.kernel.org>
Cc: <clang-built-linux@googlegroups.com>,
<linux-kernel@vger.kernel.org>, <yj.chiang@mediatek.com>,
<masahiroy@kernel.org>, <michal.lkml@markovi.net>,
Lecopzer Chen <lecopzer.chen@mediatek.com>
Subject: [PATCH 2/2] Kbuild: lto: add make version checking
Date: Wed, 30 Jun 2021 20:14:36 +0800 [thread overview]
Message-ID: <20210630121436.19581-3-lecopzer.chen@mediatek.com> (raw)
In-Reply-To: <20210630121436.19581-1-lecopzer.chen@mediatek.com>
LTO with MODVERSION will fail in generating correct CRC because
the makefile rule doesn't work for make with version 3.8X.[1]
Thus we need to check make version during selecting on LTO Kconfig.
and the suitable version should be 4.2(40200) which release in 2016[2].
[1] https://lore.kernel.org/lkml/20210616080252.32046-1-lecopzer.chen@mediatek.com/
[2] https://ftp.gnu.org/gnu/make/
Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
---
arch/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/Kconfig b/arch/Kconfig
index c45b770d3579..1571957bade5 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -632,6 +632,7 @@ config HAS_LTO_CLANG
def_bool y
# Clang >= 11: https://github.com/ClangBuiltLinux/linux/issues/510
depends on CC_IS_CLANG && CLANG_VERSION >= 110000 && LD_IS_LLD && AS_IS_LLVM
+ depends on MAKE_VERSION_INT >= 40200
depends on $(success,$(NM) --help | head -n 1 | grep -qi llvm)
depends on $(success,$(AR) --help | head -n 1 | grep -qi llvm)
depends on ARCH_SUPPORTS_LTO_CLANG
--
2.18.0
next prev parent reply other threads:[~2021-06-30 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 12:14 [PATCH 0/2] Kbuild: lto: add make version checking Lecopzer Chen
2021-06-30 12:14 ` [PATCH 1/2] Kbuild: lto: add make-version macros Lecopzer Chen
2021-06-30 17:02 ` Nathan Chancellor
2021-07-01 8:52 ` Lecopzer Chen
2021-06-30 12:14 ` Lecopzer Chen [this message]
2021-06-30 17:08 ` [PATCH 2/2] Kbuild: lto: add make version checking Nathan Chancellor
2021-07-01 8:55 ` Lecopzer Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630121436.19581-3-lecopzer.chen@mediatek.com \
--to=lecopzer.chen@mediatek.com \
--cc=clang-built-linux@googlegroups.com \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=samitolvanen@google.com \
--cc=yj.chiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox