From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAFA8C4338F for ; Mon, 16 Aug 2021 15:09:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B509960F36 for ; Mon, 16 Aug 2021 15:09:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230085AbhHPPJe (ORCPT ); Mon, 16 Aug 2021 11:09:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:57448 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229550AbhHPPJe (ORCPT ); Mon, 16 Aug 2021 11:09:34 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 220BE60EFE; Mon, 16 Aug 2021 15:09:02 +0000 (UTC) Date: Mon, 16 Aug 2021 11:08:55 -0400 From: Steven Rostedt To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Daniel Bristot de Oliveira , Masahiro Yamada , Michal Marek , linux-kbuild@vger.kernel.org Subject: Re: [PATCH] Makefile: use -Wno-main in the full kernel tree Message-ID: <20210816110855.4bb594d4@oasis.local.home> In-Reply-To: <20210813224131.25803-1-rdunlap@infradead.org> References: <20210813224131.25803-1-rdunlap@infradead.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Fri, 13 Aug 2021 15:41:31 -0700 Randy Dunlap wrote: > When using gcc (SUSE Linux) 7.5.0 (on openSUSE 15.3), I see a > build warning: > > ../kernel/trace/trace_osnoise.c: In function 'start_kthread': > ../kernel/trace/trace_osnoise.c:1461:8: warning: 'main' is usually a function [-Wmain] > void *main = osnoise_main; > ^~~~ > > Quieten that warning by using "-Wno-main". It's OK to use "main" as a > declaration name in the kernel. > > Build-tested on most ARCHes. > > Signed-off-by: Randy Dunlap > Suggested-by: Steven Rostedt > Suggested-by: Linus Torvalds > Cc: Daniel Bristot de Oliveira > Cc: Masahiro Yamada > Cc: Michal Marek > Cc: linux-kbuild@vger.kernel.org > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20210812.orig/Makefile > +++ linux-next-20210812/Makefile > @@ -522,7 +522,7 @@ KBUILD_AFLAGS := -D__ASSEMBLY__ -fno-P > KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \ > -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE \ > -Werror=implicit-function-declaration -Werror=implicit-int \ > - -Werror=return-type -Wno-format-security \ > + -Werror=return-type -Wno-format-security -Wno-main \ Acked-by: Steven Rostedt (VMware) -- Steve > -std=gnu89 > KBUILD_CPPFLAGS := -D__KERNEL__ > KBUILD_RUST_TARGET := $(srctree)/arch/$(SRCARCH)/rust/target.json