From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57120C433F5 for ; Sat, 4 Sep 2021 18:45:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39DEE60E52 for ; Sat, 4 Sep 2021 18:45:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237382AbhIDSqi (ORCPT ); Sat, 4 Sep 2021 14:46:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28310 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234085AbhIDSqh (ORCPT ); Sat, 4 Sep 2021 14:46:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630781135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XjthgrevUBZJ832z2lXXWto4HUwNpTuWMITMN6nK1VY=; b=FWhaJpqGbsXhHeZ9AMdkgee07Tf6CFLxWJPd6j8XdxOKAFoeDL3DG9tkTfsxLpREEtYlNN B4TQrclNA3uU35wM5o/DLRm/V7SM0ztswlpT+cpVkyoW8dhv2K0r4AcZcjATkqXtgmKt3+ Y85DYrL+Ja4LAfJ1AJenAZgB4c++i9o= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-458--6rKNYdbNGS3sbBPQScu2Q-1; Sat, 04 Sep 2021 14:45:34 -0400 X-MC-Unique: -6rKNYdbNGS3sbBPQScu2Q-1 Received: by mail-oo1-f71.google.com with SMTP id w6-20020a4adec6000000b0028b7d13a4c8so1614145oou.13 for ; Sat, 04 Sep 2021 11:45:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XjthgrevUBZJ832z2lXXWto4HUwNpTuWMITMN6nK1VY=; b=e7qRSKAA93uFYZTuYUch07mvPhRgghyULIWZaA1cJz2DrLywcWLh/5Sm9ps0AqRN+F 3HhqNPQAgY/FSaprOF/uuNwmuJaLBdDjc0VZucWsO3uniPn4cFY8ylp2Jjt0MExpsjHu wPmU4WFvsC0hqENKrHTbB9chyw7loUMTEjxXAeknYq5NhNl5xOpNj4Kvrc3H0vL1aYmM 39jfsWyr5nWKlBx6zQkf8zOkvnmn/9zLdrTp9jutJSfwS4iMe2fvWVUZBhGuX4piKgGd kt5S3UBNdiIqKGvrHCuvQ1fsCR1ttrSjiVuyuUnGbPUoNfS8DFm9z4z5OiC0lhiAXRSm P8Hg== X-Gm-Message-State: AOAM533BlStAaTxeu7pGiAr+dxZW5ywRIS0Lb4RUjTOPS9Yzwm9p0CD6 Woc75+IxKkWhoksZz/3E7hEcyDT/qy2iESHYV0dm/hC0aIhRzOfA1CHV+MO5XOAjvQu35vW+maM 7O5wuDHfc83sl88iKgPYzygQz X-Received: by 2002:a9d:7f07:: with SMTP id j7mr4457113otq.84.1630781133857; Sat, 04 Sep 2021 11:45:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwd+0Ndb1obwV/jkLARxO2aOSiCZgjjZqUYWuMzun/6W9DJNXLkpCgI9oURFGhqzgg3dVG8bw== X-Received: by 2002:a9d:7f07:: with SMTP id j7mr4457104otq.84.1630781133660; Sat, 04 Sep 2021 11:45:33 -0700 (PDT) Received: from treble ([2600:1700:6e32:6c00::15]) by smtp.gmail.com with ESMTPSA id c3sm598416oiy.30.2021.09.04.11.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Sep 2021 11:45:33 -0700 (PDT) Date: Sat, 4 Sep 2021 11:45:30 -0700 From: Josh Poimboeuf To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Michal Marek , Nick Desaulniers , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 03/13] kbuild: store the objtool command in *.cmd files Message-ID: <20210904184530.k6nwfesugx2su2hy@treble> References: <20210831074004.3195284-1-masahiroy@kernel.org> <20210831074004.3195284-4-masahiroy@kernel.org> <20210904180434.qkdbs27i5f2vtoxv@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210904180434.qkdbs27i5f2vtoxv@treble> Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Sat, Sep 04, 2021 at 11:04:37AM -0700, Josh Poimboeuf wrote: > On Tue, Aug 31, 2021 at 04:39:54PM +0900, Masahiro Yamada wrote: > > objtool_dep includes include/config/{ORC_UNWINDER,STACK_VALIDATION} > > so that all the objects are rebuilt when any of CONFIG_ORC_UNWINDER > > and CONFIG_STACK_VALIDATION is toggled. > > > > As you can see in 'objtool_args', there are more CONFIG options > > that affect the objtool command line. > > > > Adding more and more include/config/* is ugly and unmaintainable. > > > > Another issue is that non-standard objects are needlessly rebuilt. > > Objects specified as OBJECT_FILES_NON_STANDARD is not processed by > > objtool, but they are rebuilt anyway when CONFIG_ORC_UNWINDER or > > CONFIG_STACK_VALIDATION is toggled. This is not a big deal, but > > better to fix. > > > > A cleaner and more precise fix is to include the objtool command in > > *.cmd files so any command change is naturally detected by if_change. > > Nice improvement, thanks! > > s/CONFIG_ORC_UNWINDER/CONFIG_UNWINDER_ORC/g > > And yes, this means the original ORC unwinder dependency didn't > work: > > > -objtool_dep = $(objtool_obj) \ > > - $(wildcard include/config/ORC_UNWINDER \ > > - include/config/STACK_VALIDATION) With the typos fixed, and this dependency bug mentioned in the commit log: Acked-by: Josh Poimboeuf -- Josh