From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06190C433F5 for ; Tue, 25 Jan 2022 03:44:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355385AbiAYDoB (ORCPT ); Mon, 24 Jan 2022 22:44:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1445660AbiAXVEm (ORCPT ); Mon, 24 Jan 2022 16:04:42 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52A8BC06808F for ; Mon, 24 Jan 2022 12:04:20 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id l24-20020a17090aec1800b001b55738f633so309565pjy.1 for ; Mon, 24 Jan 2022 12:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HWwbmK/pAa8TicZndugMntIsGVz9WaQyv1NGfSzTgcw=; b=evyr4/5YrkVKxbwBNuvYxJPRCdA1sS+6XauE9QA/AOykrR1cFC5lAmQtnSW4Ni9gnD HRxJURxVyLSZoQ/nFrB3dPmgsdCU8KkKuxmhjkd0VELhaN+Br1rppOIEfAwAx2mDVMWD Hx6SOeIczWZB2HIfdkCHMLsgs3toX5mM6kres= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HWwbmK/pAa8TicZndugMntIsGVz9WaQyv1NGfSzTgcw=; b=7aoOcPANE3w5XD79vrYFHj5MWmjwJbylIT3bxzdKlUKQNAvTunru0J75sfvw0gkXrk UL/OqBDjd/DT4eSUpqiesRvCfNbgZ/Mp97Sg6HWkzevhpAnjJsHIjUNDzCh+8tsOmU+V 5/0LIUgvBex5RWyWn2SIwfUCnqCNA4bVBTOqM+GUelDAAwjgL68GCK8Yqs4a9+CuwvWP OWOGbaCgzNY+5S6vq3gPN8GVSH8hHLV0+8jiPFHrgVReXvmOmAWI4b/zSvMMteW5Cfwy Fm/BkvDc+Ox5t0uXRvshTizwAvsHsej50dV+Ho0Br2x0F3PpSmtScgLV/AsokrPqEO7m z9CQ== X-Gm-Message-State: AOAM533Wg+hgSutPOd65dl6tNWAZljTyAPQ8/hUE+QyYd0uMFLLJ71kx Z+zG3CuNNX3gKfFEkJkGsLK5IPIL9IPpqg== X-Google-Smtp-Source: ABdhPJyey0HzmygEmv9p2/wz3TGvEUw5WhWIlrs4My5MbuEhhFNmubVbuxVL85Pw43NTudYXYZas3w== X-Received: by 2002:a17:902:8ec9:b0:149:8864:cfd4 with SMTP id x9-20020a1709028ec900b001498864cfd4mr15745741plo.16.1643054659774; Mon, 24 Jan 2022 12:04:19 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id n34sm15246142pfv.209.2022.01.24.12.04.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 12:04:19 -0800 (PST) Date: Mon, 24 Jan 2022 12:04:15 -0800 From: Kees Cook To: Nick Desaulniers Cc: Masahiro Yamada , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Michal Marek , carnil@debian.org, "Gustavo A . R . Silva" , Nathan Chancellor Subject: Re: [PATCH] Revert "Makefile: Do not quote value for CONFIG_CC_IMPLICIT_FALLTHROUGH" Message-ID: <202201241203.BC2D1B63@keescook> References: <20220120053100.408816-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Mon, Jan 24, 2022 at 11:55:43AM -0800, Nick Desaulniers wrote: > + Salvatore, Kees, Gustavo, Nathan > > On Wed, Jan 19, 2022 at 9:31 PM Masahiro Yamada wrote: > > > > This reverts commit cd8c917a56f20f48748dd43d9ae3caff51d5b987. > > > > Commit 129ab0d2d9f3 ("kbuild: do not quote string values in > > include/config/auto.conf") provided the final solution. Oh nice! > > > > Now reverting the temporary workaround. > > > > Signed-off-by: Masahiro Yamada > > Reviewed-by: Nick Desaulniers Reviewed-by: Kees Cook -Kees > > > --- > > > > Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index 3f07f0f04475..c94559a97dca 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -778,7 +778,7 @@ stackp-flags-$(CONFIG_STACKPROTECTOR_STRONG) := -fstack-protector-strong > > KBUILD_CFLAGS += $(stackp-flags-y) > > > > KBUILD_CFLAGS-$(CONFIG_WERROR) += -Werror > > -KBUILD_CFLAGS += $(KBUILD_CFLAGS-y) $(CONFIG_CC_IMPLICIT_FALLTHROUGH:"%"=%) > > +KBUILD_CFLAGS += $(KBUILD_CFLAGS-y) $(CONFIG_CC_IMPLICIT_FALLTHROUGH) > > > > ifdef CONFIG_CC_IS_CLANG > > KBUILD_CPPFLAGS += -Qunused-arguments > > -- > > 2.32.0 > > > > > -- > Thanks, > ~Nick Desaulniers -- Kees Cook