Re: [PATCH v1 1/1] Makefile.extrawarn: Turn off -Werror when extra warnings are enabled

Masahiro Yamada
2022-03-25T14:35:06Z

On Fri, Mar 25, 2022 at 10:13 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> When `make W=1 ...` is executed the level 1 warnings become errors,
> due to recent change in some of the defconfigs, and fail the build.
> Since there are a lot of warnings on the level 1 are still present
> in the defconfigs at least for x86, let disable -Werror in such case.

commit b339ec9c229aaf399296a120d7be0e34fbc355ca
made WERROR default to COMPILE_TEST.

WERROR should not be enabled for regular builds.

b9080ba4a6ec should be reverted.

> Fixes: b9080ba4a6ec ("x86/defconfig: Enable WERROR")
> Suggested-by: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> scripts/Makefile.extrawarn | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
> index 650d0b8ceec3..c81d74ef6c90 100644
> --- a/scripts/Makefile.extrawarn
> +++ b/scripts/Makefile.extrawarn
> @@ -94,3 +94,10 @@ KBUILD_CFLAGS += $(call cc-option, -Wpacked-bitfield-compat)
> KBUILD_CPPFLAGS += -DKBUILD_EXTRA_WARN3
>
> endif
> +
> +#
> +# Turn off -Werror when extra warnings are enabled
> +#
> +ifneq ($(KBUILD_EXTRA_WARN),)
> + KBUILD_CFLAGS += -Wno-error
> +endif
> --
> 2.35.1
>

--
Best Regards
Masahiro Yamada