Re: [PATCH v1 1/1] Makefile.extrawarn: Turn off -Werror when extra warnings are enabled

Andy Shevchenko
2022-03-25T20:00:21Z

On Fri, Mar 25, 2022 at 10:18:06AM -0700, Linus Torvalds wrote:
> On Fri, Mar 25, 2022 at 6:13 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > +#
> > +# Turn off -Werror when extra warnings are enabled
> > +#
> > +ifneq ($(KBUILD_EXTRA_WARN),)
> > + KBUILD_CFLAGS += -Wno-error
> > +endif
>
> NAK.
>
> If you enabled CONFIG_WERROR, then you get CONFIG_WERROR.
>
> If you enabled W=1, then you get extra warnings.
>
> If you enabled both, then you get extra warnings and they are errors.
>
> This patch is just stupid.

Fair enough.

--
With Best Regards,
Andy Shevchenko