Re: [PATCH 0/8] generic command line v4

Sean Anderson
2022-09-22T20:45:16Z

On 4/16/21 12:09 AM, Daniel Walker wrote:
>
> v4 release changes
>
> * Updated insert-sys-cert tool to change command line symbols after
> compilation.
>
> This tool is used to release binary kernels internally to companies
> and then later insert certificates for each product by consumers of
> the binary kernel. Cisco uses this tool for this purpose.
>
> Cisco has a similar need for the command line to be modified on a
> binary released kernels similar to how certificates are setup.
>
> * Added global symbols to hold append and prepend values.
>
> These changes follow the system certificate code to allow the
> insert-sys-cert tool to be used.
>
> * Added a test case to confirm functionality.
>
> Seemed sensible to add this to make sure everything is working.
>
> * Dropped powerpc changes
>
> Christophe Leroy has reservations about the features for powerpc. I
> don't think his reservations are founded, and these changes should
> fully work on powerpc. However, I dropped these changes so Christophe
> can have more time to get comfortable with the changes.
>
>
> Enjoy!
>
>
> Daniel Walker (8):
> CMDLINE: add generic builtin command line
> scripts: insert-sys-cert: add command line insert capability
> scripts: insert-sys-cert: change name to insert-symbol
> CMDLINE: mips: convert to generic builtin command line
> drivers: firmware: efi: libstub: enable generic commandline
> CMDLINE: x86: convert to generic builtin command line
> of: allow sending a NULL value to early_init_dt_scan_chosen
> CMDLINE: arm64: convert to generic builtin command line
>
> arch/arm64/Kconfig | 33 +--
> arch/arm64/include/asm/setup.h | 2 +
> arch/arm64/kernel/idreg-override.c | 9 +-
> arch/mips/Kconfig | 4 +-
> arch/mips/Kconfig.debug | 44 ----
> arch/mips/configs/ar7_defconfig | 9 +-
> arch/mips/configs/bcm47xx_defconfig | 8 +-
> arch/mips/configs/bcm63xx_defconfig | 15 +-
> arch/mips/configs/bmips_be_defconfig | 11 +-
> arch/mips/configs/bmips_stb_defconfig | 11 +-
> arch/mips/configs/capcella_defconfig | 11 +-
> arch/mips/configs/ci20_defconfig | 10 +-
> arch/mips/configs/cu1000-neo_defconfig | 10 +-
> arch/mips/configs/cu1830-neo_defconfig | 10 +-
> arch/mips/configs/e55_defconfig | 4 +-
> arch/mips/configs/generic_defconfig | 6 +-
> arch/mips/configs/gpr_defconfig | 18 +-
> arch/mips/configs/loongson3_defconfig | 13 +-
> arch/mips/configs/mpc30x_defconfig | 7 +-
> arch/mips/configs/tb0219_defconfig | 7 +-
> arch/mips/configs/tb0226_defconfig | 7 +-
> arch/mips/configs/tb0287_defconfig | 7 +-
> arch/mips/configs/workpad_defconfig | 11 +-
> arch/mips/include/asm/setup.h | 2 +
> arch/mips/kernel/relocate.c | 17 +-
> arch/mips/kernel/setup.c | 36 +--
> arch/mips/pic32/pic32mzda/early_console.c | 2 +-
> arch/mips/pic32/pic32mzda/init.c | 3 +-
> arch/x86/Kconfig | 44 +---
> arch/x86/kernel/setup.c | 18 +-
> .../firmware/efi/libstub/efi-stub-helper.c | 29 +++
> drivers/firmware/efi/libstub/efi-stub.c | 9 +
> drivers/firmware/efi/libstub/efistub.h | 1 +
> drivers/firmware/efi/libstub/x86-stub.c | 13 +-
> drivers/of/fdt.c | 44 ++--
> include/linux/cmdline.h | 103 ++++++++
> init/Kconfig | 78 ++++++
> lib/Kconfig | 4 +
> lib/Makefile | 3 +
> lib/generic_cmdline.S | 53 ++++
> lib/test_cmdline1.c | 139 ++++++++++
> scripts/Makefile | 2 +-
> .../{insert-sys-cert.c => insert-symbol.c} | 243 ++++++++++++------
> 43 files changed, 716 insertions(+), 394 deletions(-)
> create mode 100644 include/linux/cmdline.h
> create mode 100644 lib/generic_cmdline.S
> create mode 100644 lib/test_cmdline1.c
> rename scripts/{insert-sys-cert.c => insert-symbol.c} (72%)
>

For an arm64 platform (after rebasing):

Tested-by: Sean Anderson <sean.anderson@seco.com>