public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Jakub Sitnicki <jakub@cloudflare.com>
To: linux-kernel@vger.kernel.org
Cc: kernel-team@cloudflare.com, linux-kbuild@vger.kernel.org,
	x86@kernel.org, Akinobu Mita <akinobu.mita@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] fault-inject: Enable stacktrace filter for x86-64
Date: Thu, 10 Nov 2022 12:30:34 +0100	[thread overview]
Message-ID: <20221110113034.17563-1-jakub@cloudflare.com> (raw)

Stacktrace filtering for fault injection has been disabled on x86-64 since
2007 due to the lack of a DWARF unwinder. See commit 6d690dcac92a ("fault
injection: disable stacktrace filter for x86-64").

In 2017, the ORC unwider, an alternative to DWARF unwinder has been added
in commit ee9f8fce9964 ("x86/unwind: Add the ORC unwinder").

We can now re-enable the stacktrace filter for x86-64.

Cc: linux-kbuild@vger.kernel.org
Cc: x86@kernel.org
Cc: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
---
 lib/Kconfig.debug | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 3fc7abffc7aa..32c5329b0dd9 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1963,7 +1963,6 @@ config FAIL_SUNRPC
 config FAULT_INJECTION_STACKTRACE_FILTER
 	bool "stacktrace filter for fault-injection capabilities"
 	depends on FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT
-	depends on !X86_64
 	select STACKTRACE
 	depends on FRAME_POINTER || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86
 	help
-- 
2.38.1


             reply	other threads:[~2022-11-10 11:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 11:30 Jakub Sitnicki [this message]
2022-11-11 16:41 ` [PATCH] fault-inject: Enable stacktrace filter for x86-64 Akinobu Mita
2022-11-14  9:56   ` Jakub Sitnicki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221110113034.17563-1-jakub@cloudflare.com \
    --to=jakub@cloudflare.com \
    --cc=akinobu.mita@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=kernel-team@cloudflare.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox