public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Lobakin <alexandr.lobakin@intel.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Alexander Lobakin <alexandr.lobakin@intel.com>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Nicolas Schier" <nicolas@fjasle.eu>,
	Nathan Chancellor <nathan@kernel.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>
Subject: Re: [PATCH v3 3/5] kbuild: add read-file macro
Date: Wed,  7 Dec 2022 17:22:08 +0100	[thread overview]
Message-ID: <20221207162208.2200189-1-alexandr.lobakin@intel.com> (raw)
In-Reply-To: <20221207154044.2181347-1-alexandr.lobakin@intel.com>

From: Alexander Lobakin <alexandr.lobakin@intel.com>
Date: Wed, 7 Dec 2022 16:40:44 +0100

> From: Masahiro Yamada <masahiroy@kernel.org>
> Date: Sun, 27 Nov 2022 07:56:22 +0900
> 
> > Since GNU Make 4.2, $(file ...) supports the read operater '<', which
> > is useful to read a file without forking any process. No warning is
> > shown even if the input file is missing.

[...]

> Great stuff. Used it in my upcoming series to simplify things, works
> as expected.
> 
> sed-syms = $(subst $(space),\|,$(foreach file,$(sym-files-y),$(call read-file,$(file))))
> 
> The only thing that came to my mind while I was implementing the
> oneliner above: maybe add ability to read multiple files? For now,
> I used a foreach, could it be somehow incorporated into read-file
> already?

Oh, nevermind. This one also works:

sed-syms = $(subst $(space),\|,$(call read-file,$(sym-files-y)))

So I believe read-file works for an arbitrary number of files.

> 
> Besides that:
> 
> Reviewed-and-tested-by: Alexander Lobakin <alexandr.lobakin@intel.com>

[...]

> > -- 
> > 2.34.1
> 
> Thanks,
> Olek

Thanks!
Olek

  reply	other threads:[~2022-12-07 16:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-26 22:56 [PATCH v3 1/5] kbuild: add test-{le,ge,lt,gt} macros Masahiro Yamada
2022-11-26 22:56 ` [PATCH v3 2/5] kbuild: implement {gcc,clang}-min-version only with built-in functions Masahiro Yamada
2022-11-26 22:56 ` [PATCH v3 3/5] kbuild: add read-file macro Masahiro Yamada
2022-12-07 15:40   ` Alexander Lobakin
2022-12-07 16:22     ` Alexander Lobakin [this message]
2022-12-10 14:10       ` Masahiro Yamada
2022-12-10 21:02         ` Nicolas Schier
2022-12-12 14:37           ` Alexander Lobakin
2022-11-26 22:56 ` [PATCH v3 4/5] kconfig: refactor Makefile to reduce process forks Masahiro Yamada
2022-11-26 22:56 ` [PATCH v3 5/5] kbuild: check Make version Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221207162208.2200189-1-alexandr.lobakin@intel.com \
    --to=alexandr.lobakin@intel.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nicolas@fjasle.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox