From: Alexey Dobriyan <adobriyan@gmail.com>
To: masahiroy@kernel.org
Cc: adobriyan@gmail.com, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] menuconfig: reclaim vertical space
Date: Sat, 11 Mar 2023 14:42:48 +0300 [thread overview]
Message-ID: <20230311114248.36587-3-adobriyan@gmail.com> (raw)
In-Reply-To: <20230311114248.36587-1-adobriyan@gmail.com>
Menuconfig has lots of vertical space wasted: on my system there are
17 lines of useful information about config options and 14 lines of
useless fluff: legend, horizontal separators and shadows.
Sitation is even worse on smaller terminals because fixed vertical
lines do not go away, but config option lines do, further decreasing
informational density. Minimum reasonable 80×24 text console has only
10(!) lines of menus presented which is less than half of the screen.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
| 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog/menubox.c
index 5eb67c04821f..dc608914c636 100644
--- a/scripts/kconfig/lxdialog/menubox.c
+++ b/scripts/kconfig/lxdialog/menubox.c
@@ -183,14 +183,14 @@ int dialog_menu(const char *title, const char *prompt,
if (height < MENUBOX_HEIGTH_MIN || width < MENUBOX_WIDTH_MIN)
return -ERRDISPLAYTOOSMALL;
- height -= 4;
+ height -= 2;
menu_height = height - 10;
max_choice = MIN(menu_height, item_count());
/* center dialog box on screen */
- x = (getmaxx(stdscr) - width) / 2;
- y = (getmaxy(stdscr) - height) / 2;
+ x = 0;
+ y = 2;
dialog = newwin(height, width, y, x);
keypad(dialog, TRUE);
--
2.39.2
next prev parent reply other threads:[~2023-03-11 11:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 11:42 [PATCH 1/3] menuconfig: delete shadows, prepare for vertical space reclaim Alexey Dobriyan
2023-03-11 11:42 ` [PATCH 2/3] menuconfig: reclaim horizontal space Alexey Dobriyan
2023-03-13 0:29 ` Randy Dunlap
2023-03-13 19:27 ` Alexey Dobriyan
2023-03-11 11:42 ` Alexey Dobriyan [this message]
2023-03-13 0:29 ` [PATCH 3/3] menuconfig: reclaim vertical space Randy Dunlap
2023-03-21 6:02 ` Masahiro Yamada
2023-03-13 0:29 ` [PATCH 1/3] menuconfig: delete shadows, prepare for vertical space reclaim Randy Dunlap
2023-03-21 5:35 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230311114248.36587-3-adobriyan@gmail.com \
--to=adobriyan@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox