Re: [PATCH v5 03/21] modpost: remove get_prettyname()

Masahiro Yamada
2023-05-20T13:33:12Z

On Thu, May 18, 2023 at 6:44 AM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Sun, May 14, 2023 at 8:27 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > This is the last user of get_pretty_name() - it is just used to
> > distinguish whether the symbol is a function or not. It is not
> > valuable information.
>
> I thought it's a nice touch. Not like it should slow things down
> unless there are extable warnings to report. May we keep it?

I do not think so.

The ex_table quite often points to assembly code, where
the distinction of function/data is not so important.

The extable has a lot of code just to print annoyingly
long error messages.

--
Best Regards
Masahiro Yamada