Re: [PATCH 0/2] Fix CFI failures with GCOV_PROFILE_ALL

Sami Tolvanen
2023-06-23T20:40:26Z

On Fri, Jun 23, 2023 at 9:32 AM Kees Cook <keescook@chromium.org> wrote:
>
> On Fri, Jun 23, 2023 at 12:11:41AM +0000, Sami Tolvanen wrote:
> > Hi folks,
> >
> > The following two patches fix CFI failures with GCOV_PROFILE_ALL,
> > where the compiler injects indirectly called functions to object
> > files that otherwise contain no executable code, and are not
> > processed by objtool or don't have CFI enabled. This results in
> > missing or incorrect type hashes during boot and when modules are
> > loaded.
> >
> > Sami Tolvanen (2):
> > kbuild: Fix CFI failures with GCOV
> > kbuild: Disable GCOV for *.mod.o
> >
> > init/Makefile | 1 +
> > scripts/Makefile.modfinal | 2 +-
> > scripts/Makefile.vmlinux | 1 +
> > 3 files changed, 3 insertions(+), 1 deletion(-)
>
> Nice hunting!
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> Should these get Cc: stable tags maybe?

I was under the impression that Fixes: tags would be sufficient these
days, but agreed, explicit Cc: probably wouldn't hurt.

Sami