From: Jesse Taube <mr.bossman075@gmail.com>
To: linux-kbuild@vger.kernel.org
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Jesse Taube <Mr.Bossman075@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Stephen Boyd <sboyd@kernel.org>
Subject: [PATCH v1] kconfig: nconf: Keep position after jump search
Date: Sat, 5 Aug 2023 23:16:58 -0400 [thread overview]
Message-ID: <20230806031658.1656667-1-Mr.Bossman075@gmail.com> (raw)
In this Menuconfig, pressing the key in the (#) prefix will jump
directly to that location. You will be returned to the current search
results after exiting this new menu.
In nconfig, exiting always returns to the top of the search output, not
to where the (#) was displayed on the search output screen.
This patch fixes that by saving the current position in the search.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/r/20230805034445.2508362-1-Mr.Bossman075@gmail.com/
Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
---
scripts/kconfig/nconf.c | 3 ++-
scripts/kconfig/nconf.gui.c | 12 +++++++++++-
scripts/kconfig/nconf.h | 1 +
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
index 172dc8fdd3ef..536332286c2f 100644
--- a/scripts/kconfig/nconf.c
+++ b/scripts/kconfig/nconf.c
@@ -749,7 +749,7 @@ static void search_conf(void)
struct gstr res;
struct gstr title;
char *dialog_input;
- int dres;
+ int dres, vscroll = 0, hscroll = 0;
bool again;
title = str_new();
@@ -790,6 +790,7 @@ static void search_conf(void)
res = get_relations_str(sym_arr, &head);
dres = show_scroll_win_ext(main_window,
"Search Results", str_get(&res),
+ &vscroll, &hscroll,
handle_search_keys, &data);
again = false;
if (dres >= '1' && dres <= '9') {
diff --git a/scripts/kconfig/nconf.gui.c b/scripts/kconfig/nconf.gui.c
index bf015895053c..a3f7c921d6c2 100644
--- a/scripts/kconfig/nconf.gui.c
+++ b/scripts/kconfig/nconf.gui.c
@@ -501,11 +501,12 @@ void show_scroll_win(WINDOW *main_window,
const char *title,
const char *text)
{
- (void)show_scroll_win_ext(main_window, title, (char *)text, NULL, NULL);
+ (void)show_scroll_win_ext(main_window, title, NULL, NULL, (char *)text, NULL, NULL);
}
/* layman's scrollable window... */
int show_scroll_win_ext(WINDOW *main_window, const char *title, char *text,
+ int *vscroll, int *hscroll,
extra_key_cb_fn extra_key_cb, void *data)
{
int res;
@@ -522,6 +523,11 @@ int show_scroll_win_ext(WINDOW *main_window, const char *title, char *text,
PANEL *panel;
bool done = false;
+ if (hscroll)
+ start_x = *hscroll;
+ if (vscroll)
+ start_y = *vscroll;
+
getmaxyx(stdscr, lines, columns);
/* find the widest line of msg: */
@@ -624,6 +630,10 @@ int show_scroll_win_ext(WINDOW *main_window, const char *title, char *text,
start_x = total_cols-text_cols;
}
+ if (hscroll)
+ *hscroll = start_x;
+ if (vscroll)
+ *vscroll = start_y;
del_panel(panel);
delwin(win);
refresh_all_windows(main_window);
diff --git a/scripts/kconfig/nconf.h b/scripts/kconfig/nconf.h
index 912f668c5772..ab836d582664 100644
--- a/scripts/kconfig/nconf.h
+++ b/scripts/kconfig/nconf.h
@@ -81,6 +81,7 @@ int dialog_inputbox(WINDOW *main_window,
const char *init, char **resultp, int *result_len);
void refresh_all_windows(WINDOW *main_window);
int show_scroll_win_ext(WINDOW *main_window, const char *title, char *text,
+ int *vscroll, int *hscroll,
extra_key_cb_fn extra_key_cb, void *data);
void show_scroll_win(WINDOW *main_window,
const char *title,
--
2.40.0
next reply other threads:[~2023-08-06 3:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-06 3:16 Jesse Taube [this message]
2023-08-06 3:20 ` [PATCH v1] kconfig: nconf: Keep position after jump search Jesse T
-- strict thread matches above, loose matches on Subject: below --
2023-08-06 3:20 Jesse Taube
2023-08-06 15:30 ` Randy Dunlap
2023-08-06 22:17 ` Jesse T
2023-08-07 2:37 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230806031658.1656667-1-Mr.Bossman075@gmail.com \
--to=mr.bossman075@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox