From: Greg KH <gregkh@linuxfoundation.org>
To: Shreenidhi Shedi <yesshedi@gmail.com>
Cc: dhowells@redhat.com, dwmw2@infradead.org, masahiroy@kernel.org,
nathan@kernel.org, ndesaulniers@google.com, nicolas@fjasle.eu,
linux-kernel@vger.kernel.org, sshedi@vmware.com,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v9 1/7] sign-file: use getopt_long_only for parsing input args
Date: Thu, 10 Aug 2023 07:47:40 +0200 [thread overview]
Message-ID: <2023081018-sturdily-district-6034@gregkh> (raw)
In-Reply-To: <20230809172211.343677-2-yesshedi@gmail.com>
On Wed, Aug 09, 2023 at 10:52:04PM +0530, Shreenidhi Shedi wrote:
> - getopt_long_only gives an option to use long names for options, so
> using it here to make the app usage easier.
>
> - Use more easy to remember command line argument names
>
> - Introduce cmd_opts structure to ease the handling of command line args
When you have to list a number of different things that you did in a
single patch, that usually means this needs to be split up into multiple
changes.
Please do so here, you are converting to a different api (getopt_long)
and adding new arguments (with no documentation) at the same time, which
means this is an almost impossible change to review easily. Would you
want to review this?
thanks,
greg k-h
next prev parent reply other threads:[~2023-08-10 5:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 17:22 [PATCH v9 0/7] refactor file signing program Shreenidhi Shedi
2023-08-09 17:22 ` [PATCH v9 1/7] sign-file: use getopt_long_only for parsing input args Shreenidhi Shedi
2023-08-10 5:47 ` Greg KH [this message]
2023-08-09 17:22 ` [PATCH v9 2/7] sign-file: inntroduce few new flags to make argument processing easy Shreenidhi Shedi
2023-08-10 5:48 ` Greg KH
2023-08-10 5:49 ` Greg KH
2023-08-09 17:22 ` [PATCH v9 3/7] sign-file: move file signing logic to its own function Shreenidhi Shedi
2023-08-10 5:50 ` Greg KH
2023-08-09 17:22 ` [PATCH v9 4/7] sign-file: add support to sign modules in bulk Shreenidhi Shedi
2023-08-10 5:50 ` Greg KH
2023-08-13 12:26 ` Masahiro Yamada
2023-08-09 17:22 ` [PATCH v9 5/7] sign-file: improve help message Shreenidhi Shedi
2023-08-10 6:18 ` Greg KH
2023-08-09 17:22 ` [PATCH v9 6/7] sign-file: use const with a global string constant Shreenidhi Shedi
2023-08-09 17:22 ` [PATCH v9 7/7] sign-file: fix do while styling issue Shreenidhi Shedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023081018-sturdily-district-6034@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=sshedi@vmware.com \
--cc=yesshedi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox