From: Masahiro Yamada <masahiroy@kernel.org>
To: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Nicolas Schier <nicolas@fjasle.eu>
Subject: [PATCH 03/10] modpost: disallow *driver to reference .meminit* sections
Date: Mon, 23 Oct 2023 02:06:06 +0900 [thread overview]
Message-ID: <20231022170613.2072838-3-masahiroy@kernel.org> (raw)
In-Reply-To: <20231022170613.2072838-1-masahiroy@kernel.org>
Drivers must not reference .meminit* sections, which are discarded
when CONFIG_MEMORY_HOTPLUG=n.
The reason for whitelisting "*driver" in the section mismatch check
was to allow drivers to reference symbols annotated as __devinit or
__devexit that existed in the past.
Those annotations were removed by the following commits:
- 54b956b90360 ("Remove __dev* markings from init.h")
- 92e9e6d1f984 ("modpost.c: Stop checking __dev* section mismatches")
Remove the wrong whitelist.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
scripts/mod/modpost.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index bcc334b28a2c..792ba9da0f27 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1006,12 +1006,6 @@ static int secref_whitelist(const char *fromsec, const char *fromsym,
"*_console")))
return 0;
- /* symbols in data sections that may refer to meminit sections */
- if (match(fromsec, PATTERNS(DATA_SECTIONS)) &&
- match(tosec, PATTERNS(ALL_XXXINIT_SECTIONS)) &&
- match(fromsym, PATTERNS("*driver")))
- return 0;
-
/*
* symbols in data sections must not refer to .exit.*, but there are
* quite a few offenders, so hide these unless for W=1 builds until
--
2.40.1
next prev parent reply other threads:[~2023-10-22 17:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 17:06 [PATCH 01/10] modpost: remove ALL_EXIT_DATA_SECTIONS macro Masahiro Yamada
2023-10-22 17:06 ` [PATCH 02/10] linux/init: remove __memexit* annotations Masahiro Yamada
2023-10-22 18:24 ` Arnd Bergmann
2023-10-22 17:06 ` Masahiro Yamada [this message]
2023-10-22 17:06 ` [PATCH 04/10] modpost: remove more symbol patterns from the section check whitelist Masahiro Yamada
2023-10-23 23:28 ` Nathan Chancellor
2023-10-28 11:56 ` Masahiro Yamada
2023-10-22 17:06 ` [PATCH 05/10] modpost: remove MEM_INIT_SECTIONS macro Masahiro Yamada
2023-10-22 17:06 ` [PATCH 06/10] modpost: remove EXIT_SECTIONS macro Masahiro Yamada
2023-10-22 17:06 ` [PATCH 07/10] modpost: disallow the combination of EXPORT_SYMBOL and __meminit* Masahiro Yamada
2023-10-22 17:06 ` [PATCH 08/10] modpost: use ALL_INIT_SECTIONS for the section check from DATA_SECTIONS Masahiro Yamada
2023-10-22 17:06 ` [PATCH 09/10] modpost: merge sectioncheck table entries regarding init/exit sections Masahiro Yamada
2023-10-22 17:06 ` [PATCH 10/10] modpost: squash ALL_{INIT,EXIT}_TEXT_SECTIONS to ALL_TEXT_SECTIONS Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231022170613.2072838-3-masahiroy@kernel.org \
--to=masahiroy@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox