From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C4E6C4332F for ; Tue, 31 Oct 2023 11:46:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344051AbjJaLqM (ORCPT ); Tue, 31 Oct 2023 07:46:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344046AbjJaLqL (ORCPT ); Tue, 31 Oct 2023 07:46:11 -0400 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7952BE4 for ; Tue, 31 Oct 2023 04:46:07 -0700 (PDT) Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-66d87554434so38259406d6.2 for ; Tue, 31 Oct 2023 04:46:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1698752766; x=1699357566; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=7RyJr69Zjkg4/uGgk720yPGxk6Fi/nOg06RfMojBpdE=; b=VXANg8GdP4W9YDhfLRG4D4er9me3m3U8EhriPO3RC6qTU+FruFkF0WpkTvmisDLm7B ZIQUQnjnok8Tu3zhjIypEst+GVp9eMbKIJ24MgvqJEKTD4CV9X39jpNZcgwCT6CMEXac cTi4Yismv4x/EouGK5pDrlekyLv0M+QVSplvo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698752766; x=1699357566; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7RyJr69Zjkg4/uGgk720yPGxk6Fi/nOg06RfMojBpdE=; b=fr/WsohztFexlDaaTdy2Z69QofJXsy1TmBHWSx5GJ1ICHkqrDbEvEYPHK+nltgmSa1 m20IlATa0bOr5ewGeykRv0HJ6Dew+KAOWMfNeb/fPfotqTM3pqsCihrnqJFI1zFKbgzI Cx+ogdd4iwvGEP5VGE8EWO7kkn8fQPAET46D9saFdDLBcyRYzJhLFFnTsh33er7KZACA jCo4OMVmycq3BhuD2MkBqkBuz/FMsZIKMUDgZS9Btf1fTsIrXz+l4fxLb5LvUdguQiJu /+SJyYeBFW5jqAYkOijFUYauwUpY5+u2fm7M8qLe2S8nztpOeyLevVisIhPEGBElT7e8 kcyA== X-Gm-Message-State: AOJu0YywcAHpEsap11U5vF5g7qO2aDzAEzzRayEj9mlw6Noe7txhjttf Ax1UrsJw6e9XtvYBVF+9aMwkxg== X-Google-Smtp-Source: AGHT+IFTS994PF2eivbjl4D87zli4XLFKRYnso6wsgAbR5iJm+HvYpJK5Qak0c/vkJYa00RCMxjYZw== X-Received: by 2002:ad4:5aa1:0:b0:66d:1b4c:e85e with SMTP id u1-20020ad45aa1000000b0066d1b4ce85emr15585877qvg.4.1698752766592; Tue, 31 Oct 2023 04:46:06 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-0000-0000-0000-013d.res6.spectrum.com. [2603:6081:7b00:6400::13d]) by smtp.gmail.com with ESMTPSA id o5-20020a056214180500b0066d11743b3esm449095qvw.34.2023.10.31.04.46.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 04:46:06 -0700 (PDT) Date: Tue, 31 Oct 2023 07:46:04 -0400 From: Tom Rini To: Masahiro Yamada Cc: "Russell King (Oracle)" , Simon Glass , linux-arm-kernel@lists.infradead.org, U-Boot Mailing List , Catalin Marinas , Nathan Chancellor , Nick Desaulniers , Nick Terrell , Nicolas Schier , Will Deacon , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] arm64: boot: Support Flat Image Tree Message-ID: <20231031114604.GG496310@bill-the-cat> References: <20231026072628.4115527-1-sjg@chromium.org> <20231026072628.4115527-4-sjg@chromium.org> <20231030161209.GU496310@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Tue, Oct 31, 2023 at 04:03:18PM +0900, Masahiro Yamada wrote: > On Tue, Oct 31, 2023 at 1:12 AM Tom Rini wrote: > > > > On Mon, Oct 30, 2023 at 03:35:34PM +0000, Russell King (Oracle) wrote: > > > On Sun, Oct 29, 2023 at 05:46:12AM +1300, Simon Glass wrote: > > > > Hi Masahiro, > > > > > > > > Sure, but that is a separate issue, isn't it? We already support > > > > various boot targets in arm64 but not one that includes the DTs, so > > > > far as I can see. The old arm 'uImage' target is pretty out-of-date > > > > now. > > > > > > Does that mean it can be removed? ;) > > > > > > I've NAK'd FIT support on 32-bit Arm in the past, and I remain of the > > > opinion that boot loader specific packaging of the kernel should not > > > be in the kernel but should be external to it - even more so given the > > > multi-platform nature of 32-bit Arm kernels. > > > > I'll point it out here rather than Simon. As part of > > https://github.com/open-source-firmware FIT is a standard and not "boot > > loader specific". And one of the points of a FIT image is that you can > > easily support multi-platform kernels in a single file (without > > optimizing things further, at a cost in tens of milliseconds on a Pi 3 > > anyhow) and with user-controlled security. > > > > -- > > Tom > > > > It is a copy of the document in U-Boot. > > The file was split into two, but the content is the same. > > > [original in U-Boot] > https://github.com/u-boot/u-boot/blob/v2023.10/doc/usage/fit/source_file_format.rst > > > [flat-image-tree] > https://github.com/open-source-firmware/flat-image-tree/blob/v0.8/source/chapter1-introduction.rst > https://github.com/open-source-firmware/flat-image-tree/blob/v0.8/source/chapter2-source-file-format.rst Yes, it would have been a bad idea to change a 15 year old format as part of getting it included in some standards, and we'd also recently cleaned it up to rST. Similar comments would I expect be true of turning grub.cfg in to extlinux.conf and all of the organizations that has moved along, and anything else that wasn't developed by committee at some Standards organization. -- Tom