From: Matthew Maurer <mmaurer@google.com>
To: "Masahiro Yamada" <masahiroy@kernel.org>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
"John Ogness" <john.ogness@linutronix.de>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Matthew Maurer" <mmaurer@google.com>,
"Zhen Lei" <thunder.leizhen@huawei.com>,
"Nhat Pham" <nphamcs@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Marc Aurèle La France" <tsi@tuyoix.net>
Cc: linux-kbuild@vger.kernel.org, "Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Nick Desaulniers" <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: [PATCH 3/3] rust: Require RUST_MODULES for module support
Date: Wed, 8 Nov 2023 02:26:25 +0000 [thread overview]
Message-ID: <20231108022651.645950-6-mmaurer@google.com> (raw)
In-Reply-To: <20231108022651.645950-2-mmaurer@google.com>
Currently, we don't support MODVERSIONS for Rust symbols. For users that
want to use Rust in the kernel but for whom MODVERSIONS is required,
this allows the use of built-in Rust code even with MODVERSIONS enabled.
It may additionally allow code-size reduction by avoiding exporting
symbols that won't be used without Rust modules.
Signed-off-by: Matthew Maurer <mmaurer@google.com>
---
init/Kconfig | 21 +++++++++++++++++----
kernel/module/Kconfig | 1 +
rust/exports.c | 4 ++++
3 files changed, 22 insertions(+), 4 deletions(-)
diff --git a/init/Kconfig b/init/Kconfig
index 9ffb103fc927..6912dbbee3f1 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1885,7 +1885,6 @@ config RUST
bool "Rust support"
depends on HAVE_RUST
depends on RUST_IS_AVAILABLE
- depends on !MODVERSIONS
depends on !GCC_PLUGINS
depends on !RANDSTRUCT
depends on !DEBUG_INFO_BTF || PAHOLE_HAS_LANG_EXCLUDE
@@ -1896,13 +1895,27 @@ config RUST
This allows other Rust-related options, like drivers written in Rust,
to be selected.
- It is also required to be able to load external kernel modules
- written in Rust.
-
See Documentation/rust/ for more information.
If unsure, say N.
+config RUST_MODULES
+ bool "Rust Module Support"
+ depends on RUST
+ depends on MODULES
+ rust_modules
+ help
+ Enables support for Rust Modules in the kernel.
+
+ This is required to load external kernel modules written in Rust.
+
+ The two primary reasons to consider disabling this are:
+ * Allow MODVERSIONS support
+ * Allow additional code to be optimized out by the compiler if you
+ know that you'll only be using built-in Rust code.
+
+ If unsure, say Y.
+
config RUSTC_VERSION_TEXT
string
depends on RUST
diff --git a/kernel/module/Kconfig b/kernel/module/Kconfig
index 0ea1b2970a23..a76128887618 100644
--- a/kernel/module/Kconfig
+++ b/kernel/module/Kconfig
@@ -158,6 +158,7 @@ config MODULE_UNLOAD_TAINT_TRACKING
shown. If unsure, say N.
config MODVERSIONS
+ depends on !RUST_MODULES
bool "Module versioning support"
help
Usually, you have to use modules compiled with your kernel.
diff --git a/rust/exports.c b/rust/exports.c
index 83e2a7070cae..96b706048ed4 100644
--- a/rust/exports.c
+++ b/rust/exports.c
@@ -13,7 +13,11 @@
#include <linux/module.h>
+#ifdef CONFIG_RUST_MODULES
#define EXPORT_SYMBOL_RUST_GPL(sym) extern int sym; EXPORT_SYMBOL_GPL(sym)
+#else
+#define EXPORT_SYMBOL_RUST_GPL(sym)
+#endif
#include "exports_core_generated.h"
#include "exports_alloc_generated.h"
--
2.42.0.869.gea05f2083d-goog
next prev parent reply other threads:[~2023-11-08 2:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 2:26 [PATCH 0/3] Support MODVERSIONS by disabling Rust modules Matthew Maurer
2023-11-08 2:26 ` [PATCH 1/3] kconfig: Extend expr_depends_symbol to recurse Matthew Maurer
2023-11-08 2:26 ` [PATCH 2/3] kconfig: Add special rust_modules config option Matthew Maurer
2023-11-08 3:01 ` Randy Dunlap
2023-11-09 7:43 ` Boris Kolpackov
2023-11-08 2:26 ` Matthew Maurer [this message]
2023-11-09 12:44 ` [PATCH 0/3] Support MODVERSIONS by disabling Rust modules Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108022651.645950-6-mmaurer@google.com \
--to=mmaurer@google.com \
--cc=a.hindborg@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nphamcs@gmail.com \
--cc=ojeda@kernel.org \
--cc=paulmck@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=thunder.leizhen@huawei.com \
--cc=tsi@tuyoix.net \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox