Re: [PATCH 0/8] generic command line v6

Andrew Morton
2023-11-10T01:51:46Z

On Thu, 9 Nov 2023 17:38:04 -0800 Daniel Walker <danielwa@cisco.com> wrote:

> This release is an up-rev of the v5 patches. No additional features have
> been added. Some changes were mode to function names and some changes to
> Kconfig dependencies. Also updated the config conversion for mips.
>
> There are a number of people who have expressed interest in these
> patches either by asking for them to be merge or testing them. If
> people are so inclined please continue to request them to be merge
> or to ask the status of the next release. It's helpful to motivate me to
> release them again and for the maintainers to see the interest
> generated.
>
> These patches have been used by Cisco Systems, Inc. on millions of
> released products to great effect. Hopefully they can be used by the
> entire Linux eco system.
>

fyi, none of the above is suitable for a [0/N] changelog - it's all
transitory stuff which tells readers nothing much about what the
patchset does.

And that info is sorely missed. I can see that it's a code cleanup,
but I'm sure Cisco wouldn't expend resources to maintain such a thing.
There's something else here.

In [1/8] I see "Even with mips and powerpc enhancement the needs of
Cisco are not met on these platforms" and "This unified implementation
offers the same functionality needed by Cisco on all platform which we
enable it on".

Well OK, what are these needs? What functionality changes does this
patchset offer which Cisco finds useful? IOW, what were the
requirements? What's wrong with the old code and how does this
patchset fix/enhance that?

I see the patchset updates nothing under Documentation/. Should it do
so? Could it do so?

I don't know what is the expected merge patch for this work. I can
grab them if no other maintainer is in the firing line.