Re: [PATCH 0/8] generic command line v6

Christophe Leroy
2023-11-23T06:23:51Z

Le 10/11/2023 à 02:38, Daniel Walker a écrit :
> This release is an up-rev of the v5 patches. No additional features have
> been added. Some changes were mode to function names and some changes to
> Kconfig dependencies. Also updated the config conversion for mips.
>
> There are a number of people who have expressed interest in these
> patches either by asking for them to be merge or testing them. If
> people are so inclined please continue to request them to be merge
> or to ask the status of the next release. It's helpful to motivate me to
> release them again and for the maintainers to see the interest
> generated.

Good, then lets work all together and get the best of it.

Your series has good features like the update of the command line addons
without rebuild, including updating of the signature when applicable.
However your series still has weaknesses it had in previous versions. I
was hopping we could work all together to improve it, but you have been
repeatedly telling that my proposal doesn't fit your needs without
explaining why. Can we work in a more win-win spirit this time ?

By the way, for the record, here is a link to a series I sent out as an
exemple of what it could look like. The intention at that time was not
to have a concurrent series, but just to show what I meant in my
comments, because exemples are often more explicit than words. That
series was considered more mature and closer to a mergeable state than
yours at that time. Link to the said series:
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?state=*&series=237158

Your series only converts a few architectures, and I can't see any
demonstration that it will be possible to convert other architectures as
a follow-up without too much pain.

>
> These patches have been used by Cisco Systems, Inc. on millions of
> released products to great effect. Hopefully they can be used by the
> entire Linux eco system.

This is not an argument. Billions of computers are running Micr*s*ft
Windows, does it make Windows better ? Do IBM or Google claim about the
million equipment they are sending out with special Linux features ?
Showing objectively what's the benefit of your features without
referring to Cisco would be better.

>
> My apologies on the length between releases. I will try to release more
> often.

Christophe

>
>
> Daniel Walker (8):
> CMDLINE: add generic builtin command line
> scripts: insert-sys-cert: add command line insert capability
> scripts: insert-sys-cert: change name to insert-symbol
> CMDLINE: mips: convert to generic builtin command line
> drivers: firmware: efi: libstub: enable generic commandline
> CMDLINE: x86: convert to generic builtin command line
> of: replace command line handling
> CMDLINE: arm64: convert to generic builtin command line
>
> arch/arm64/Kconfig | 33 +--
> arch/arm64/include/asm/setup.h | 4 +
> arch/arm64/include/uapi/asm/setup.h | 2 +
> arch/arm64/kernel/idreg-override.c | 9 +-
> arch/arm64/kernel/pi/kaslr_early.c | 14 +-
> arch/mips/Kconfig | 4 +-
> arch/mips/Kconfig.debug | 44 ----
> arch/mips/configs/ar7_defconfig | 12 +-
> arch/mips/configs/bcm47xx_defconfig | 10 +-
> arch/mips/configs/bcm63xx_defconfig | 21 +-
> arch/mips/configs/bmips_be_defconfig | 17 +-
> arch/mips/configs/bmips_stb_defconfig | 139 ++++------
> arch/mips/configs/ci20_defconfig | 8 +-
> arch/mips/configs/cu1000-neo_defconfig | 19 +-
> arch/mips/configs/cu1830-neo_defconfig | 19 +-
> arch/mips/configs/generic_defconfig | 15 +-
> arch/mips/configs/gpr_defconfig | 33 +--
> arch/mips/configs/loongson3_defconfig | 29 +--
> arch/mips/include/asm/setup.h | 2 +
> arch/mips/kernel/relocate.c | 17 +-
> arch/mips/kernel/setup.c | 36 +--
> arch/mips/pic32/pic32mzda/early_console.c | 2 +-
> arch/mips/pic32/pic32mzda/init.c | 3 +-
> arch/x86/Kconfig | 44 +---
> arch/x86/kernel/setup.c | 18 +-
> .../firmware/efi/libstub/efi-stub-helper.c | 29 +++
> drivers/firmware/efi/libstub/efi-stub.c | 9 +
> drivers/firmware/efi/libstub/efistub.h | 1 +
> drivers/firmware/efi/libstub/x86-stub.c | 14 +-
> drivers/of/fdt.c | 22 +-
> include/linux/cmdline.h | 137 ++++++++++
> init/Kconfig | 79 ++++++
> lib/Kconfig | 4 +
> lib/Makefile | 3 +
> lib/generic_cmdline.S | 53 ++++
> lib/test_cmdline1.c | 139 ++++++++++
> scripts/Makefile | 2 +-
> .../{insert-sys-cert.c => insert-symbol.c} | 243 ++++++++++++------
> 38 files changed, 807 insertions(+), 482 deletions(-)
> create mode 100644 include/linux/cmdline.h
> create mode 100644 lib/generic_cmdline.S
> create mode 100644 lib/test_cmdline1.c
> rename scripts/{insert-sys-cert.c => insert-symbol.c} (72%)
>