Re: [PATCH v2 0/4] kbuild: Per arch/platform dtc warning levels

Masahiro Yamada
2023-11-23T07:39:14Z

On Thu, Nov 23, 2023 at 7:12 AM Rob Herring <robh@kernel.org> wrote:
>
> This series adds support to set the dtc extra warning level on a per
> arch or per platform (directory really) basis.
>
> The first version of this was just a simple per directory override for
> Samsung platforms, but Conor asked to be able to do this for all of
> riscv.
>
> For merging, either I can take the whole thing or the riscv and samsung
> patches can go via their normal trees. The added variable will have no
> effect until merged with patch 2.
>
> v1:
> - https://lore.kernel.org/all/20231116211739.3228239-1-robh@kernel.org/
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---

There were some attempts in the past to enable W=1 in particular subsystems,
so here is a similar comment.

Adding a new warning flag to W=1 is always safe without doing any compile test.

With this series, it would not be true any more because a new warning in W=1
would potentially break riscv/samsung platforms.

Linus requires a clean build (i.e. zero warning) when W= option is not given.

> Rob Herring (4):
> kbuild: Move dtc graph_child_address warning to W=2
> kbuild: Allow arch/platform override of dtc warning level
> riscv: dts: Always enable extra W=1 warnings
> arm/arm64: dts: samsung: Always enable extra W=1 warnings
>
> arch/arm/boot/dts/samsung/Makefile | 3 +++
> arch/arm64/boot/dts/exynos/Makefile | 3 +++
> arch/riscv/boot/dts/Makefile | 3 +++
> scripts/Makefile.lib | 16 +++++++++-------
> 4 files changed, 18 insertions(+), 7 deletions(-)
> ---
> base-commit: b85ea95d086471afb4ad062012a4d73cd328fa86
> change-id: 20231122-dtc-warnings-968ff83a86ed
>
> Best regards,
> --
> Rob Herring <robh@kernel.org>
>

--
Best Regards
Masahiro Yamada