From: Masahiro Yamada <masahiroy@kernel.org>
To: linux-kbuild@vger.kernel.org
Cc: Masahiro Yamada <masahiroy@kernel.org>, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] kconfig: remove unneeded symbol_empty variable
Date: Sun, 26 Nov 2023 01:35:58 +0900 [thread overview]
Message-ID: <20231125163559.824210-1-masahiroy@kernel.org> (raw)
This is used only for initializing other variables.
Use the empty string "".
Please note newval.tri is unused for S_INT/HEX/STRING.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
scripts/kconfig/symbol.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
index a76925b46ce6..f7075d148ac7 100644
--- a/scripts/kconfig/symbol.c
+++ b/scripts/kconfig/symbol.c
@@ -29,12 +29,6 @@ struct symbol symbol_no = {
.flags = SYMBOL_CONST|SYMBOL_VALID,
};
-static struct symbol symbol_empty = {
- .name = "",
- .curr = { "", no },
- .flags = SYMBOL_VALID,
-};
-
struct symbol *modules_sym;
static tristate modules_val;
@@ -346,7 +340,7 @@ void sym_calc_value(struct symbol *sym)
case S_INT:
case S_HEX:
case S_STRING:
- newval = symbol_empty.curr;
+ newval.val = "";
break;
case S_BOOLEAN:
case S_TRISTATE:
@@ -697,13 +691,12 @@ const char *sym_get_string_default(struct symbol *sym)
{
struct property *prop;
struct symbol *ds;
- const char *str;
+ const char *str = "";
tristate val;
sym_calc_visibility(sym);
sym_calc_value(modules_sym);
val = symbol_no.curr.tri;
- str = symbol_empty.curr.val;
/* If symbol has a default value look it up */
prop = sym_get_default_prop(sym);
--
2.40.1
next reply other threads:[~2023-11-25 16:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 16:35 Masahiro Yamada [this message]
2023-11-25 16:35 ` [PATCH 2/2] kconfig: default to zero if int/hex symbol lacks default property Masahiro Yamada
2023-11-25 23:10 ` Yoann Congal
2024-01-23 12:54 ` [PATCH 1/2] kconfig: remove unneeded symbol_empty variable Geert Uytterhoeven
2024-01-23 15:11 ` Yoann Congal
2024-01-24 8:09 ` Masahiro Yamada
2024-01-24 8:56 ` Yoann Congal
2024-01-24 20:12 ` Masahiro Yamada
2024-01-25 14:42 ` Yoann Congal
2024-01-26 13:20 ` Masahiro Yamada
2024-01-25 14:48 ` Geert Uytterhoeven
2024-01-24 9:52 ` Geert Uytterhoeven
2024-01-24 11:43 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231125163559.824210-1-masahiroy@kernel.org \
--to=masahiroy@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox