Re: [PATCH 09/17] arm64: convert unistd_32.h to syscall.tbl format

Catalin Marinas
2024-07-05T12:10:30Z

On Thu, Jul 04, 2024 at 04:36:03PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This is a straight conversion from the old asm/unistd32.h into the
> format used by 32-bit arm and most other architectures, calling scripts
> to generate the asm/unistd32.h header and a new asm/syscalls32.h headers.
>
> I used a semi-automated text replacement method to do the conversion,
> and then used 'vimdiff' to synchronize the whitespace and the (unused)
> names of the non-compat syscalls with the arm version.
>
> There are two differences between the generated syscalls names and the
> old version:
>
> - the old asm/unistd32.h contained only a __NR_sync_file_range2
> entry, while the arm32 version also defines
> __NR_arm_sync_file_range with the same number. I added this
> duplicate back in asm/unistd32.h.
>
> - __NR__sysctl was removed from the arm64 file a while ago, but
> all the tables still contain it. This should probably get removed
> everywhere but I added it here for consistency.
>
> On top of that, the arm64 version does not contain any references to
> the 32-bit OABI syscalls that are not supported by arm64. If we ever
> want to share the file between arm32 and arm64, it would not be
> hard to add support for both in one file.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Catalin Marinas <catalin.marinas@arm.com>