From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Olsa <jolsa@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Nicolas Schier <nicolas@fjasle.eu>,
Brian Norris <briannorris@chromium.org>,
Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH v2] Makefile: add comment to discourage tools/* addition for kernel builds
Date: Fri, 19 Jul 2024 15:55:32 -0700 [thread overview]
Message-ID: <20240719225532.mpm36wh6xa3acl7r@treble> (raw)
In-Reply-To: <20240717182828.1527504-1-masahiroy@kernel.org>
On Thu, Jul 18, 2024 at 03:28:19AM +0900, Masahiro Yamada wrote:
> Kbuild provides scripts/Makefile.host to build host programs used for
> building the kernel. Unfortunately, there are two exceptions that opt
> out of Kbuild. The build system under tools/ is a cheesy replica, and
> cause issues. I was recently poked about a problem in the tools build
> system, which I do not maintain (and nobody maintains). [1]
>
> Without a comment, people might believe this is the right location
> because that is where objtool lives, even if a more robust Kbuild
> syntax satisfies their needs. [2]
I think the original idea (from Ingo?) was to make objtool portable so
it could be easily copied and built separately without getting too
intertwined with the kernel source.
I think that's still a useful goal. To my knowledge it's been used in
at least one other code base and could be used elsewhere going forward
as much of its functionality might be transferable to other code bases.
Also being in tools helps it shares library code (libsubcmd) and
synced headers with perf (and others).
If there's some other way to make it portable and allow it to share code
with other tools that then I wouldn't object to moving it to scripts.
Or, if the main problem is that there are two custom build systems (one
of them being a cheap knockoff), could kbuild be made portable enough to
be used in tools?
--
Josh
next prev parent reply other threads:[~2024-07-19 22:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 18:28 [PATCH v2] Makefile: add comment to discourage tools/* addition for kernel builds Masahiro Yamada
2024-07-18 17:54 ` Sami Tolvanen
2024-07-19 22:55 ` Josh Poimboeuf [this message]
2024-07-20 14:22 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240719225532.mpm36wh6xa3acl7r@treble \
--to=jpoimboe@kernel.org \
--cc=briannorris@chromium.org \
--cc=jolsa@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=peterz@infradead.org \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox