Re: [PATCH v3] rust: query the compiler for dylib path

Miguel Ojeda
2024-10-09T14:28:58Z

On Wed, Oct 9, 2024 at 4:16 PM Tamir Duberstein <tamird@gmail.com> wrote:
>
> Rust proc-macro crates are loaded by the compiler at compile-time, so
> are always dynamic libraries; on macOS, these artifacts get a .dylib
> extension rather than .so.
>
> Replace hardcoded paths ending in .so with paths obtained from the
> compiler.

Nit: this should mention what the overall purpose of the patch is,
i.e. "why we are doing this?", i.e. supporting macOS builds. It is
maybe obvious since macOS is mentioned (in the "what does this patch
do?" part), but it is best to be explicit.

> Co-developed-by: Fiona Behrens <me@kloenk.dev>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Please read the section of the documentation I linked, it contains an
example on how this should be done, i.e. the Co-developed-by tag
cannot be on its own:

https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

`scripts/checkpatch.pl` also warns about this -- please run patches through it:

WARNING: Co-developed-by and Signed-off-by: name/email do not match

Cheers,
Miguel