Re: [PATCH] rust: query the compiler for dylib path

Miguel Ojeda
2024-10-09T12:43:02Z

On Wed, Oct 9, 2024 at 12:48 AM Tamir Duberstein <tamird@gmail.com> wrote:
>
> Rust proc-macro crates are loaded by the compiler at compile-time, so
> are always dynamic libraries; on macOS, these artifacts get a .dylib
> extension rather than .so.

What is the status of the macOS build support? A link would be nice here.

> Signed-off-by: Fiona Behrens <me@kloenk.dev>

Is this patch Fiona's/yours/both? Depending on that, different tags
are needed here (including `From:`). Please see:

https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

> @@ -9,6 +9,8 @@ import logging
> import os
> import pathlib
> import sys
> +import os
> +import subprocess

Nit: double import, unsorted.

Thanks!

Cheers,
Miguel