Re: [PATCH v2 5/7] streamline_config.pl: fix: implement choice for kconfigs

David Hunter
2024-11-27T13:18:10Z

On 11/5/24 18:33, Masahiro Yamada wrote:
> I previously suggested checking how the 'if' statement is handled.
> https://lore.kernel.org/lkml/CAK7LNAQ8D4OVT81iTVs8jjrBXX6Zgwc+VJ_vb7hb4J-vCZZN=g@mail.gmail.com/
>
I think I understand now what you were saying. I misunderstood what you
were saying because I thought that you were saying that the "if" blocks
were not implemented.

To paraphrase, I believe that you are saying that the "choice" blocks
should have a similar style to the "if" blocks.

I will take a look at the patch that you sent and figure out how it
would work. I would like some clarification on the information in the
choice blocks that are not "depends." Should those also have the same
style as the "if" block?

I am not sure if you saw this email:
https://lore.kernel.org/all/994efba2-2829-4874-b5fa-9f5317f6ea6b@gmail.com/

There are lots of information, specifically "prompts" and "defaults"
that are distributed to each of the config options in the "choice" blocks.

>
> BTW, 'menu' also can have 'depends on'.
>
>
> menu "menu"
> depends on FOO
> config A
> bool "A"
> config B
> bool "B"
> endmenu
>
>
> This is not implemented, either.
>
> I am not sure how much effort should be invested in this script, though.
>
>
I will look into distributing the "menu" information.