From: Peter Zijlstra <peterz@infradead.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: mcgrof@kernel.org, x86@kernel.org, petr.pavlu@suse.com,
samitolvanen@google.com, da.gomez@samsung.com,
masahiroy@kernel.org, nathan@kernel.org, nicolas@fjasle.eu,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
linux-kbuild@vger.kernel.org, hch@infradead.org,
gregkh@linuxfoundation.org
Subject: Re: [RFC] module: Strict per-modname namespaces
Date: Fri, 8 Nov 2024 16:35:52 +0100 [thread overview]
Message-ID: <20241108153552.GD6497@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <04F6A88E-FC15-4184-A1F7-A5EE443997DD@zytor.com>
On Fri, Nov 08, 2024 at 04:28:58PM +0100, H. Peter Anvin wrote:
> >@@ -1700,11 +1715,7 @@ static void check_exports(struct module *mod)
> > s->crc_valid = exp->crc_valid;
> > s->crc = exp->crc;
> >
> >- basename = strrchr(mod->name, '/');
> >- if (basename)
> >- basename++;
> >- else
> >- basename = mod->name;
> >+ basename = mod_basename(mod->name);
> >
> > if (!contains_namespace(&mod->imported_namespaces, exp->namespace)) {
> > modpost_log(!allow_missing_ns_imports,
>
> I presume this only applies to code compiled as dynamic modules, not compiled into the kernel?
Yes, the built-in modules get the regular linker to resolve relocations.
Nothing much we can do about that.
prev parent reply other threads:[~2024-11-08 15:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 19:02 [RFC] module: Strict per-modname namespaces Peter Zijlstra
2024-11-06 23:42 ` Luis Chamberlain
2024-11-07 5:46 ` Christoph Hellwig
2024-11-07 8:12 ` Masahiro Yamada
2024-11-07 12:50 ` Peter Zijlstra
2024-11-07 5:39 ` Christoph Hellwig
2024-11-08 8:08 ` Geert Uytterhoeven
2024-11-07 6:12 ` Greg KH
2024-11-07 7:55 ` Masahiro Yamada
2024-11-07 11:58 ` Peter Zijlstra
2024-11-07 15:27 ` Peter Zijlstra
2024-11-08 15:28 ` H. Peter Anvin
2024-11-08 15:35 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241108153552.GD6497@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=da.gomez@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox