Re: [RFC][PATCH 1/8] module: Prepare for script

Christoph Hellwig
2024-11-11T11:36:30Z

On Mon, Nov 11, 2024 at 11:54:31AM +0100, Peter Zijlstra wrote:
> Since sed doesn't like multi-line make sure all EXPORT_SYMBOL_NS
> things are a single line.

Eww. Just use coccinelle or another tool not so simplistic.

> @@ -375,8 +372,7 @@ int otx2_cptlf_register_done_interrupts(
> otx2_cptlf_unregister_done_interrupts(lfs);
> return ret;
> }
> -EXPORT_SYMBOL_NS_GPL(otx2_cptlf_register_done_interrupts,
> - CRYPTO_DEV_OCTEONTX2_CPT);
> +EXPORT_SYMBOL_NS_GPL(otx2_cptlf_register_done_interrupts, CRYPTO_DEV_OCTEONTX2_CPT);
>
> void otx2_cptlf_free_irqs_affinity(struct otx2_cptlfs_info *lfs)
> {
> --- a/include/kunit/visibility.h
> +++ b/include/kunit/visibility.h
> @@ -24,8 +24,7 @@
> * in test file in order to use symbols.
> * @symbol: the symbol identifier to export
> */
> - #define EXPORT_SYMBOL_IF_KUNIT(symbol) EXPORT_SYMBOL_NS(symbol, \
> - EXPORTED_FOR_KUNIT_TESTING)
> + #define EXPORT_SYMBOL_IF_KUNIT(symbol) EXPORT_SYMBOL_NS(symbol, EXPORTED_FOR_KUNIT_TESTING)
> #else
> #define VISIBLE_IF_KUNIT static
> #define EXPORT_SYMBOL_IF_KUNIT(symbol)
> --- a/sound/soc/codecs/tas2781-fmwlib.c
> +++ b/sound/soc/codecs/tas2781-fmwlib.c
> @@ -2310,8 +2310,7 @@ int tasdevice_select_tuningprm_cfg(void
> out:
> return prog_status;
> }
> -EXPORT_SYMBOL_NS_GPL(tasdevice_select_tuningprm_cfg,
> - SND_SOC_TAS2781_FMWLIB);
> +EXPORT_SYMBOL_NS_GPL(tasdevice_select_tuningprm_cfg, SND_SOC_TAS2781_FMWLIB);
>
> int tasdevice_prmg_load(void *context, int prm_no)
> {
> @@ -2392,8 +2391,7 @@ void tasdevice_tuning_switch(void *conte
> TASDEVICE_BIN_BLK_PRE_SHUTDOWN);
> }
> }
> -EXPORT_SYMBOL_NS_GPL(tasdevice_tuning_switch,
> - SND_SOC_TAS2781_FMWLIB);
> +EXPORT_SYMBOL_NS_GPL(tasdevice_tuning_switch, SND_SOC_TAS2781_FMWLIB);
>
> MODULE_DESCRIPTION("Texas Firmware Support");
> MODULE_AUTHOR("Shenghao Ding, TI, <shenghao-ding@ti.com>");
>
>
---end quoted text---