From: Nicolas Schier <nicolas@fjasle.eu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] kbuild: do not pass -r to genksyms when *.symref does not exist
Date: Thu, 14 Nov 2024 11:56:34 +0100 [thread overview]
Message-ID: <20241114-nondescript-overjoyed-cricket-52ccdb@lindesnes> (raw)
In-Reply-To: <20241111171753.2917697-1-masahiroy@kernel.org>
On Tue, Nov 12, 2024 at 02:17:40AM +0900, Masahiro Yamada wrote:
> There is no need to pass '-r /dev/null', which is no-op.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> scripts/Makefile.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 8f423a1faf50..36eae845a3e3 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -110,7 +110,7 @@ $(obj)/%.i: $(obj)/%.c FORCE
> genksyms = scripts/genksyms/genksyms \
> $(if $(1), -T $(2)) \
> $(if $(KBUILD_PRESERVE), -p) \
> - -r $(or $(wildcard $(2:.symtypes=.symref)), /dev/null)
> + $(addprefix -r , $(wildcard $(2:.symtypes=.symref)))
>
> # These mirror gensymtypes_S and co below, keep them in synch.
> cmd_gensymtypes_c = $(CPP) -D__GENKSYMS__ $(c_flags) $< | $(genksyms)
> --
> 2.43.0
>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
prev parent reply other threads:[~2024-11-14 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 17:17 [PATCH 1/2] kbuild: do not pass -r to genksyms when *.symref does not exist Masahiro Yamada
2024-11-11 17:17 ` [PATCH 2/2] kbuild: remove support for single %.symtypes build rule Masahiro Yamada
2024-11-14 10:57 ` Nicolas Schier
2024-11-14 10:56 ` Nicolas Schier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241114-nondescript-overjoyed-cricket-52ccdb@lindesnes \
--to=nicolas@fjasle.eu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox