From: Peter Zijlstra <peterz@infradead.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Maennich <maennich@google.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] module: fixups after module namespace conversion
Date: Tue, 3 Dec 2024 11:26:03 +0100 [thread overview]
Message-ID: <20241203102603.GA21636@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241203102124.3147478-1-masahiroy@kernel.org>
On Tue, Dec 03, 2024 at 07:21:04PM +0900, Masahiro Yamada wrote:
>
> [1/3]
> Commit cdd30ebb1b9f added double-quotes to enclose the variable in the
> semantic patch, scripts/coccinelle/misc/add_namespace.cocci.
> Since then, 'make nsdepds' always changes the missing import to silly code:
> MODULE_IMPORT_NS("ns");
>
> [2/3]
> MODULE_IMPORT_NS("") is misleading in the context of documentation
> about MODULE_IMPORT_NS() tags in general.
>
> [3/3]
> Convert DEFAULT_SYMBOL_NAMESPACE from a macro expansion to a string
> literal. There is no good reason to keep inconsistency in the default
> case.
>
>
>
> Masahiro Yamada (3):
> scripts/nsdeps: get 'make nsdeps' working again
> doc: module: revert misconversions for MODULE_IMPORT_NS()
> module: Convert default symbol namespace to string literal
Thanks, I totally missed the DEFAULT_SYMBOL_NAMESPACE thing.
And my coccinelle foo is non-existent, I would've never spotted that.
next prev parent reply other threads:[~2024-12-03 10:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 10:21 [PATCH 0/3] module: fixups after module namespace conversion Masahiro Yamada
2024-12-03 10:21 ` [PATCH 1/3] scripts/nsdeps: get 'make nsdeps' working again Masahiro Yamada
2024-12-03 10:21 ` [PATCH 2/3] doc: module: revert misconversions for MODULE_IMPORT_NS() Masahiro Yamada
2024-12-03 10:21 ` [PATCH 3/3] module: Convert default symbol namespace to string literal Masahiro Yamada
2024-12-03 10:41 ` Uwe Kleine-König
2024-12-03 10:26 ` Peter Zijlstra [this message]
2024-12-03 11:09 ` [PATCH 0/3] module: fixups after module namespace conversion Masahiro Yamada
2024-12-03 16:23 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241203102603.GA21636@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maennich@google.com \
--cc=masahiroy@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox