From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Brendan Jackman <jackmanb@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 2/2] kbuild: Add option to fail build on vmlinux objtool issues
Date: Fri, 13 Dec 2024 16:52:23 -0800 [thread overview]
Message-ID: <20241214005223.f2fansikbwovm3oo@jpoimboe> (raw)
In-Reply-To: <20241213-objtool-strict-v1-2-fd388f9d971f@google.com>
On Fri, Dec 13, 2024 at 11:31:31AM +0000, Brendan Jackman wrote:
> NOINSTR_VALIDATION is pretty helpful for detecting bugs, I would like
> my build to fail when those bugs arise.
>
> If we wanted to we could enable this for individual warnings, it seems
> unlikely there's a use-case for that though. So for now I've just added
> a global setting for vmlinux.
>
> Signed-off-by: Brendan Jackman <jackmanb@google.com>
Note that *any* objtool warning has a good change of being a major bug
in the kernel or compiler which could result in crashing the kernel or
breaking the livepatch consistency model. So the option shouldn't be
restricted to noinstr builds only. In which case it should be called
CONFIG_OBJTOOL_WERROR, analagous to CONFIG_WERROR.
We definitely need this, though it will likely break a lot of robot
builds, so it wouldn't be a good idea to merge it until after the
holidays. Though once the patches are ready I could throw it on a git
branch to see how bad the robot breakage is.
--
Josh
next prev parent reply other threads:[~2024-12-14 0:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 11:31 [PATCH 0/2] objtool: Add option to fail build on vmlinux warnings Brendan Jackman
2024-12-13 11:31 ` [PATCH 1/2] objtool: Add --fail-on-warn Brendan Jackman
2024-12-14 0:36 ` Josh Poimboeuf
2024-12-16 9:55 ` Brendan Jackman
2024-12-13 11:31 ` [PATCH 2/2] kbuild: Add option to fail build on vmlinux objtool issues Brendan Jackman
2024-12-14 0:52 ` Josh Poimboeuf [this message]
2024-12-16 10:00 ` Brendan Jackman
2024-12-18 9:08 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241214005223.f2fansikbwovm3oo@jpoimboe \
--to=jpoimboe@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jackmanb@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox