From: Nathan Chancellor <nathan@kernel.org>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Brendan Jackman <jackmanb@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v3 0/2] objtool: Add option to fail build on vmlinux warnings
Date: Fri, 7 Feb 2025 14:41:13 -0700 [thread overview]
Message-ID: <20250207214113.GB661404@ax162> (raw)
In-Reply-To: <20250207025127.2sy74bhcu6wtbo6a@jpoimboe>
On Thu, Feb 06, 2025 at 06:51:27PM -0800, Josh Poimboeuf wrote:
> On Thu, Feb 06, 2025 at 10:10:36AM -0700, Nathan Chancellor wrote:
> > Right, I think gating on '!COMPILE_TEST' would not be a terrible way to
> > introduce it. We would definitely want to remove that dependency as
> > soon as possible because we want compile testers to be qble to find
> > these problems and have them be noticeable but it should make the
> > introduction of CONFIG_OBJTOOL_WERROR less disruptive.
>
> I want to get CONFIG_OBJTOOL_WERROR merged soon. I'm working on some
> other patches to go along with it that will hopefully ease some of the
> pain. I'll post those soon and then hopefully we can get it into
> linux-next.
Sounds good to me, getting it into linux-next will give us a good idea
of how disruptive it may be.
> I didn't quite follow the OBJTOOL_FLAGS idea. We already have
> OBJTOOL_ARGS which allows adding arguments (though not removing them),
> was it mean to be something like that?
Yes, I should have prefaced "if it does not already exist" since I did
not realize that there was already support for adding to objtool
arguments via an environment/make variable already.
Cheers,
Nathan
prev parent reply other threads:[~2025-02-07 21:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 14:05 [PATCH v3 0/2] objtool: Add option to fail build on vmlinux warnings Brendan Jackman
2025-01-13 14:05 ` [PATCH v3 1/2] objtool: Add --Werror Brendan Jackman
2025-01-14 17:24 ` Nathan Chancellor
2025-01-14 18:17 ` Josh Poimboeuf
2025-01-13 14:05 ` [PATCH v3 2/2] kbuild: Add option to fail build on vmlinux objtool issues Brendan Jackman
2025-01-14 0:14 ` [PATCH v3 0/2] objtool: Add option to fail build on vmlinux warnings Josh Poimboeuf
2025-01-30 15:55 ` Brendan Jackman
2025-01-30 18:30 ` Nathan Chancellor
2025-01-31 10:44 ` Brendan Jackman
2025-01-31 20:49 ` Nathan Chancellor
2025-02-06 15:05 ` Brendan Jackman
2025-02-06 17:10 ` Nathan Chancellor
2025-02-07 2:51 ` Josh Poimboeuf
2025-02-07 10:16 ` Brendan Jackman
2025-02-07 21:41 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250207214113.GB661404@ax162 \
--to=nathan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jackmanb@google.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox