Re: [PATCH v2 4/4] x86: Get rid of Makefile.postlink

Petr Pavlu
2025-03-12T12:36:01Z

On 3/11/25 12:17, Borislav Petkov wrote:
> + Petr for 9d9173e9ceb6
>
> @Petr, you can find the whole thread on lore.
>
> On Tue, Mar 11, 2025 at 12:06:21PM +0100, Ard Biesheuvel wrote:
>> From: Ard Biesheuvel <ardb@kernel.org>
>>
>> Instead of generating the vmlinux.relocs file (needed by the
>> decompressor build to construct the KASLR relocation tables) as a
>> vmlinux postlink step, which is dubious because it depends on data that
>> is stripped from vmlinux before the build completes, generate it from
>> vmlinux.unstripped, which has been introduced specifically for this
>> purpose.
>>
>> This ensures that each artifact is rebuilt as needed, rather than as a
>> side effect of another build rule.
>>
>> This effectively reverts commit
>>
>> 9d9173e9ceb6 ("x86/build: Avoid relocation information in final vmlinux")
>>
>> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>

For what it's worth, the changes look to me as an improvement over the
previous implementation.

--
Thanks,
Petr