Linux kbuild/kconfig development
 help / color / mirror / Atom feed
From: David Disseldorp <ddiss@suse.de>
To: Gang Yan <yangang@kylinos.cn>
Cc: Nathan Chancellor <nathan@kernel.org>,
	Nicolas Schier <nicolas.schier@linux.dev>,
	linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] gen_initramfs.sh: add the positive check for timestamp
Date: Wed, 15 Oct 2025 16:42:23 +1100	[thread overview]
Message-ID: <20251015164223.2190a747.ddiss@suse.de> (raw)
In-Reply-To: <20251015021831.355966-1-yangang@kylinos.cn>

Hi,

On Wed, 15 Oct 2025 10:18:31 +0800, Gang Yan wrote:

> The gen_initramfs.sh script has already checked that 'date' returned
> somthing, but it did not verify the content of the return. This patch
> adds a check to ensure the correctness of the timestamp obtained via the
> 'date -d'.

This change doesn't seem unreasonable, but I think failing when an
unsupported date is explicitly provided is an improvement over silent
fallback to time() based initramfs mtimes.
A change to the kbuild.rst KBUILD_BUILD_TIMESTAMP documentation would be
worthwhile. Could you add a note regarding initramfs and pre-epoch times
there?

Thanks, David

  reply	other threads:[~2025-10-15  5:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15  2:18 [PATCH] gen_initramfs.sh: add the positive check for timestamp Gang Yan
2025-10-15  5:42 ` David Disseldorp [this message]
2025-10-15 13:39 ` Nicolas Schier
  -- strict thread matches above, loose matches on Subject: below --
2025-10-15 10:18 GangYan
2025-10-15 10:27 ` David Disseldorp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251015164223.2190a747.ddiss@suse.de \
    --to=ddiss@suse.de \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=nicolas.schier@linux.dev \
    --cc=yangang@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox