Re: [PATCH] kconfig: fix static linking of nconf

[Nathan Chancellor <nathan@kernel.org>]

On Sat, Jan 10, 2026 at 12:48:08PM +0100, Arkadiusz Kozdra wrote:
> When running make nconfig with a static linking host toolchain,
> the libraries are linked in an incorrect order,
> resulting in errors similar to the following:
> 
> $ MAKEFLAGS='HOSTCC=cc\ -static' make nconfig
> /usr/bin/ld: /usr/lib64/gcc/x86_64-unknown-linux-gnu/14.2.1/../../../../lib64/libpanel.a(p_new.o): in function `new_panel':
> (.text+0x13): undefined reference to `_nc_panelhook_sp'
> /usr/bin/ld: (.text+0x6c): undefined reference to `_nc_panelhook_sp'
> 
> Fixes: 1c5af5cf9308 ("kconfig: refactor ncurses package checks for building mconf and nconf")
> Signed-off-by: Arusekk <floss@arusekk.pl>
> ---
>  scripts/kconfig/nconf-cfg.sh | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/scripts/kconfig/nconf-cfg.sh b/scripts/kconfig/nconf-cfg.sh
> index a20290b1a37d..fedebbd6b2c8 100755
> --- a/scripts/kconfig/nconf-cfg.sh
> +++ b/scripts/kconfig/nconf-cfg.sh
> @@ -6,8 +6,8 @@ set -eu
>  cflags=$1
>  libs=$2
>  
> -PKG="ncursesw menuw panelw"
> -PKG2="ncurses menu panel"

Is it worth a comment that the order of these packages is intentional to
support static library builds? I do not mind adding after the fact to
save you from sending a v2. I guess this situation is not too common
since 1c5af5cf9308 is over six years old at this point but if any other
dependencies become necessary in the future, it might help folks place
them in the correct order.

> +PKG="menuw panelw ncursesw"
> +PKG2="menu panel ncurses"
>  
>  if [ -n "$(command -v ${HOSTPKG_CONFIG})" ]; then
>  	if ${HOSTPKG_CONFIG} --exists $PKG; then
> @@ -28,19 +28,19 @@ fi
>  # find ncurses by pkg-config.)
>  if [ -f /usr/include/ncursesw/ncurses.h ]; then
>  	echo -D_GNU_SOURCE -I/usr/include/ncursesw > ${cflags}
> -	echo -lncursesw -lmenuw -lpanelw > ${libs}
> +	echo -lmenuw -lpanelw -lncursesw > ${libs}
>  	exit 0
>  fi
>  
>  if [ -f /usr/include/ncurses/ncurses.h ]; then
>  	echo -D_GNU_SOURCE -I/usr/include/ncurses > ${cflags}
> -	echo -lncurses -lmenu -lpanel > ${libs}
> +	echo -lmenu -lpanel -lncurses > ${libs}
>  	exit 0
>  fi
>  
>  if [ -f /usr/include/ncurses.h ]; then
>  	echo -D_GNU_SOURCE > ${cflags}
> -	echo -lncurses -lmenu -lpanel > ${libs}
> +	echo -lmenu -lpanel -lncurses > ${libs}
>  	exit 0
>  fi
>  
> -- 
> 2.51.2
>