Re: [PATCH 0/3] scripts/container: Minor fixups suggested by ruff

[Nathan Chancellor <nathan@kernel.org>]

On Fri, Jan 23, 2026 at 04:14:16PM +0100, Miguel Ojeda wrote:
> On Fri, Jan 23, 2026 at 12:27 AM Nathan Chancellor <nathan@kernel.org> wrote:
> >
> > This series fixes a few warnings that I see when running
> >
> >   $ ruff check --select C4,RUF scripts/container
> >
> > which were the few warnings from my personal ruff.toml that seemed most
> > interesting.
> 
> I haven't had time to look into the new container support yet, but
> having kernel Python scripts Ruff-clean sounds good in general, and I
> wonder -- should we consider having a `.ruff.toml` eventually?

I think that we should. Even something as simple as the one in the Ruff
docs would keep things consistent:

  https://docs.astral.sh/ruff/linter/#rule-selection

I guess the one problem there is consistency amongst developers (since
one's linting workflow is fairly personal) and having a wide range of
Python code across the tree but having a .ruff.toml for people to run if
they want it is harmless.

> At least we have a small `.pylintrc` already, which is quite recent by the way.

Ah, good to know!

> I think I recall you also using Black and/or Flake8, for
> ClangBuiltLinux-related bits perhaps?

We use Ruff and pylint for linting, yapf for formatting. Ruff can
replace flake8 outright with the right configuration in my experience.

Cheers,
Nathan