Re: [PATCH 0/3] scripts/container: Minor fixups suggested by ruff

[Nathan Chancellor <nathan@kernel.org>]

On Fri, Jan 23, 2026 at 09:26:20PM +0100, Guillaume Tucker wrote:
> Hi Nathan,
> 
> On 23/01/2026 12:27 am, Nathan Chancellor wrote:
> > Hi all,
> > 
> > This series fixes a few warnings that I see when running
> > 
> >    $ ruff check --select C4,RUF scripts/container
> > 
> > which were the few warnings from my personal ruff.toml that seemed most
> > interesting.
> > 
> > I will apply these on top of the initial scripts/container change.
> > 
> > ---
> > Nathan Chancellor (3):
> >        scripts/container: Turn runtimes class variable into a tuple
> >        scripts/container: Use list comprehension in get_names()
> >        scripts/container: Use iterable unpacking for _get_opts()
> > 
> >   scripts/container | 10 ++++++----
> >   1 file changed, 6 insertions(+), 4 deletions(-)
> > ---
> > base-commit: 6eac13c876805f61bbb588eaff5ada0b6dc603e8
> > change-id: 20260122-scripts-container-ruff-fixes-4d38fc92771a
> 
> LGTM - some of these things are arguably more a matter of individual
> taste than absolute best practices but it's good to have a
> well-defined code quality standard.  I typically use Pylint,
> Pycodestyle and Mypy, not Ruff or Black.  So for the whole series:
> 
> Reviewed-by: Guillaume Tucker <gtucker@gtucker.io>

Thanks a lot for taking a look and providing the comments. I am going to
hold off on this series for a little bit to ponder on providing a
.ruff.toml file first to ensure we have a common understanding around
Python linting in the kernel, especially given a lot of these lints can
be opinionated as you mentioned.

Cheers,
Nathan