* Re: [GIT PULL] fbdev fixes and updates for v7.0-rc1 [not found] ` <aZDpCUcIXLmuydoF@carbonx1> @ 2026-02-14 22:47 ` Linus Torvalds 2026-02-17 21:45 ` Nathan Chancellor 0 siblings, 1 reply; 2+ messages in thread From: Linus Torvalds @ 2026-02-14 22:47 UTC (permalink / raw) To: Helge Deller, Nathan Chancellor, Nicolas Schier Cc: linux-kernel, linux-fbdev, dri-devel, Linux Kbuild mailing list [ Adding Kconfig maintainers and linux-kbuild list ] On Sat, 14 Feb 2026 at 13:30, Helge Deller <deller@kernel.org> wrote: > > Linus, I'm really sorry, but I messed up drivers/gpu/drm/Kconfig while > trying to fix a merge conflict. > My patch series should not have touched drivers/gpu/drm/Kconfig at all. > That's purely my fault and not the fault of the patch author. Humm. Funky how the Kconfig parts never complained about the duplication of all those source lines, so the problem was basically entirely hidden and things still "worked" even though that Kconfig file had been so messed up. I'm not sure if the Kconfig tools could perhaps warn about this kind of duplication - we might have some of it intentionally - but it does make me go "Hmm". Nathan, Nicolas, comments? See that commit ca4ee40bf13d for the partial revert, and notice how Kconfig is entirely happy both before and after that.. Linus ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [GIT PULL] fbdev fixes and updates for v7.0-rc1 2026-02-14 22:47 ` [GIT PULL] fbdev fixes and updates for v7.0-rc1 Linus Torvalds @ 2026-02-17 21:45 ` Nathan Chancellor 0 siblings, 0 replies; 2+ messages in thread From: Nathan Chancellor @ 2026-02-17 21:45 UTC (permalink / raw) To: Linus Torvalds Cc: Helge Deller, Nicolas Schier, linux-kernel, linux-fbdev, dri-devel, Linux Kbuild mailing list Hi Linus, On Sat, Feb 14, 2026 at 02:47:47PM -0800, Linus Torvalds wrote: > [ Adding Kconfig maintainers and linux-kbuild list ] > > On Sat, 14 Feb 2026 at 13:30, Helge Deller <deller@kernel.org> wrote: > > > > Linus, I'm really sorry, but I messed up drivers/gpu/drm/Kconfig while > > trying to fix a merge conflict. > > My patch series should not have touched drivers/gpu/drm/Kconfig at all. > > That's purely my fault and not the fault of the patch author. > > Humm. Funky how the Kconfig parts never complained about the > duplication of all those source lines, so the problem was basically > entirely hidden and things still "worked" even though that Kconfig > file had been so messed up. > > I'm not sure if the Kconfig tools could perhaps warn about this kind > of duplication - we might have some of it intentionally - but it does > make me go "Hmm". > > Nathan, Nicolas, comments? See that commit ca4ee40bf13d for the > partial revert, and notice how Kconfig is entirely happy both before > and after that.. It seems like we should be able to check if we have seen an sourced Kconfig already, presumably somewhere in or around zconf_nextfile() in scripts/kconfig/lexer.l. Not sure how complicated it will be, I will see if I can wire something like that up during the next development cycle (amongst the other things on my plate). Given how wonky that looks in menuconfig and the like, maybe it is worth making that a hard error. Cheers, Nathan ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-17 21:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <aZBlTsIwTzS0tqBD@carbonx1>
[not found] ` <177110244909.2897141.11184148040863874004.pr-tracker-bot@kernel.org>
[not found] ` <aZDpCUcIXLmuydoF@carbonx1>
2026-02-14 22:47 ` [GIT PULL] fbdev fixes and updates for v7.0-rc1 Linus Torvalds
2026-02-17 21:45 ` Nathan Chancellor
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox