From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5B7A34CFC4; Mon, 23 Feb 2026 23:02:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771887753; cv=none; b=NpYZan65GizD0C+pNKFrtOaD2xYW6Cs65/bJWVTuzChpiWdjYTqwweBbfXwVljibNt+2AH5FeU7O5WwEBwfN9t/qzH2pmOFR2TtAHKgy0R4GRiTXqtd3bFmZe2BayOhBy8oyIHBd1uXj/XXveagP+tCGhYQ8Yn26yyCmaRSPD3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771887753; c=relaxed/simple; bh=nT0awucs3thOhxybhtypZ+eYhg7lv1UzxhZoWxrV7JE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sqphRfl4aNtD6t5VL2lspO1UMpjWrQoZl+HFe+TP3BCHroxfst+Y4zz+WbhojUnqCVcDE9rFsOwC/4UkFfJI3Ft/jec6FPHjECgAtviATzJin3l1Gw98PqFkbXQIRQWEU90AwUjZ9KxxjuT8Paj6JAicxZkfCEO5h0J2h5Kwkcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V+fu9p4B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V+fu9p4B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48409C116C6; Mon, 23 Feb 2026 23:02:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771887753; bh=nT0awucs3thOhxybhtypZ+eYhg7lv1UzxhZoWxrV7JE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V+fu9p4BCluguUa+f3d7BCn1pI2i9AqAEMBzkLqH4bddGKT5WSOohV6ymAwB0/TBL lXNzrl+hmSZblzdOixCvwDFcjW9iJo5ImvPlqCzkT22dc1XMIZWAMVzlyyqxTDXaZ5 4A5XwGEGtPXUctEhtggMXSRCQOq7U1cR9rpjbXPVnxUBOrPDtTlXe7A3JD/7+OhTOF pTf4SXBjLVNbVuMyClIxv9c3QaOT9qAcBGv/vWbbNANtpasn+pQ210tXeKbMh0saY3 VU3OBF9raOPDCjnuuQKM50HH+X66NKDZ7QZi6Z7SFHAdAZXCsNZW64QbGHR00fFjZH 58/1MtBytYDmg== Date: Mon, 23 Feb 2026 15:02:32 -0800 From: Kees Cook To: Nathan Chancellor Cc: Nicolas Schier , Linus Torvalds , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ard Biesheuvel , Ilias Apalodimas , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-efi@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH 2/2] kbuild: Use '-fms-anonymous-structs' if it is available Message-ID: <202602231459.2A1DD53E0@keescook> References: <20260223-fms-anonymous-structs-v1-0-8ee406d3c36c@kernel.org> <20260223-fms-anonymous-structs-v1-2-8ee406d3c36c@kernel.org> <202602231432.20F3F0CF@keescook> <20260223225311.GA2462602@ax162> Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260223225311.GA2462602@ax162> On Mon, Feb 23, 2026 at 03:53:11PM -0700, Nathan Chancellor wrote: > On Mon, Feb 23, 2026 at 02:33:35PM -0800, Kees Cook wrote: > > Series looks good to me. One style question, why go the round-trip with > > Kconfig instead of doing it all with a fallback in the Makefile: > > > > CC_FLAGS_DIALECT += $(call cc-option,-fms-anonymous-structs,-fms-extensions) > > I might be misunderstanding how Kbuild works but > arch/$(SRCARCH)/Makefile may have logic for selecting CROSS_COMPILE, > which can impact the selection of $(CC), so I cannot use cc-option prior > to its inclusion but I need CC_FLAGS_DIALECT to be included before > arch/$(SRCARCH)/Makefile in the main build so that they can be used > within it, which is only possible after Kconfig has run. This is > probably worth more flushing out in the code or a comment since it is > subtle. Will Kconfig see a different CC than Makefile? Regardless, I trust your judgement here! I actually rather prefer having it exposed via Kconfig. :) Reviewed-by: Kees Cook -Kees -- Kees Cook