From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD3F72F617C; Tue, 24 Feb 2026 20:55:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771966538; cv=none; b=sWjiiqGDKeGN32QPSiu1DM0sdCU6tk/mnREEK29J4Y7HC9MTFrJWy/6J3vGor/2H5B8zmfclU+kY1DlUGmwlt2QMxNDk2IHm8Jm4uDwrJE+SJXhTc1X70m97RxCXFN2JdJyVW80fJUth5jfBbBNSx+LDkA7j8T6YfoPu7v28BpU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771966538; c=relaxed/simple; bh=SQcVebSSVbAr9KoKj2KkC4SNEiz7WbMDmKWz7KrYMDc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WQg5ek8+3pLkSC6xNSAFZ3Cr63IIgSJK3nUIpBV1qtoU7V11KIkVVQt8iJc52TkJx+JoKhYxJnCYnXXnMdA1MTCBR8ZCrSuRprwlzEy0n7keHPKcWhgRe39arSbDlXq2cxDIG1R2ONtBGI/7RAVMKTj58HgbBywudeYhuVjfX3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C5QdJEhD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C5QdJEhD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D21D3C116D0; Tue, 24 Feb 2026 20:55:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771966538; bh=SQcVebSSVbAr9KoKj2KkC4SNEiz7WbMDmKWz7KrYMDc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C5QdJEhDu3F3RiE7rGx/Dj0PuDa8L2iA78NrEvl5azZwBu4Ri8KTCOsR7pMfcmtU3 je0zFaQMDs14Xk47ydamr6d7K/C2mLgReCJU0eQ5t1msb9+Cr7JogPuBHz98HpmyQ7 FL/1gMMXhg+L00T+Kh2KO3QlEyL82mSedV36eljnS06LPHa0h3WmsQVmUdeXN3DiC9 cEZqkUgOnFmktJdADtpZXWkrLh5++ZoIg7vfN/CCzxHt5NfLUeQ6OdSa50D7n4i6eP XnEv8Hyqpy7KHExKA4q8UQSULNu6IIGyin0jFfMRoKZyLBFOB48silsMM4b6g71d0s /Yrc0O/Gx/2jA== Date: Tue, 24 Feb 2026 13:55:29 -0700 From: Nathan Chancellor To: Kees Cook Cc: Nicolas Schier , Linus Torvalds , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ard Biesheuvel , Ilias Apalodimas , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-efi@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH 2/2] kbuild: Use '-fms-anonymous-structs' if it is available Message-ID: <20260224205529.GB3510750@ax162> References: <20260223-fms-anonymous-structs-v1-0-8ee406d3c36c@kernel.org> <20260223-fms-anonymous-structs-v1-2-8ee406d3c36c@kernel.org> <202602231432.20F3F0CF@keescook> <20260223225311.GA2462602@ax162> <202602231459.2A1DD53E0@keescook> Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202602231459.2A1DD53E0@keescook> On Mon, Feb 23, 2026 at 03:02:32PM -0800, Kees Cook wrote: > On Mon, Feb 23, 2026 at 03:53:11PM -0700, Nathan Chancellor wrote: > > On Mon, Feb 23, 2026 at 02:33:35PM -0800, Kees Cook wrote: > > > Series looks good to me. One style question, why go the round-trip with > > > Kconfig instead of doing it all with a fallback in the Makefile: > > > > > > CC_FLAGS_DIALECT += $(call cc-option,-fms-anonymous-structs,-fms-extensions) > > > > I might be misunderstanding how Kbuild works but > > arch/$(SRCARCH)/Makefile may have logic for selecting CROSS_COMPILE, > > which can impact the selection of $(CC), so I cannot use cc-option prior > > to its inclusion but I need CC_FLAGS_DIALECT to be included before > > arch/$(SRCARCH)/Makefile in the main build so that they can be used > > within it, which is only possible after Kconfig has run. This is > > probably worth more flushing out in the code or a comment since it is > > subtle. > > Will Kconfig see a different CC than Makefile? Regardless, I trust your It shouldn't, as arch/$(SRCARCH)/Makefile is included before invoking Kconfig; if the compiler changes, Kconfig will run again before building. > judgement here! I actually rather prefer having it exposed via Kconfig. > :) > > Reviewed-by: Kees Cook Thanks! Nathan