public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Ed W <lists@wildgooses.com>
Cc: Thorsten Leemhuis <regressions@leemhuis.info>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	masahiroy@kernel.org,
	Linux Kernel Build System <linux-kbuild@vger.kernel.org>,
	Nicolas Schier <nsc@kernel.org>,
	Linux kernel regressions list <regressions@lists.linux.dev>
Subject: Re: extlinux can't boot kernel after commit "kbuild: keep .modinfo section in vmlinux.unstripped"
Date: Wed, 25 Feb 2026 14:24:25 -0700	[thread overview]
Message-ID: <20260225212425.GH2755225@ax162> (raw)
In-Reply-To: <4ff9d8be-ba4c-4698-abe8-31fcf2717acf@wildgooses.com>

On Wed, Feb 25, 2026 at 11:55:06AM +0000, Ed W wrote:
> Yes, your patch works fine against my 6.18.12 kernel on my AMD64 machine and booting with extlinux
> (previously not working)

Thanks a lot for verifying! I will send this as a formal patch shortly.
I will include:

  Tested-by: Ed W <lists@wildgooses.com> # x86_64

in addition to a Reported-by, if that is okay with you. Let me know if
not and I will remove it before I apply the patch but I want to make
sure you get proper credit for helping out with this process.

> I also played around a little with some variations and it seems as
> though the adding in of the .modinfo into the strip is the key, caveat
> that in my messing around (based on inspiration from the commit [1]
> that you mention), I needed to reorder the macros to get it to
> compile. Note, I'm not suggestion this as a solution, just
> illustrating some extra info:

Yup, this is definitely another option but I still think including
.modinfo in ELF_DETAILS was dubious from the beginning because it is not
really a generic ELF section, hence splitting it out.

> --- arch/x86/boot/compressed/vmlinux.lds.S.orig    2026-02-25 10:42:45.040655315 +0000
> +++ arch/x86/boot/compressed/vmlinux.lds.S    2026-02-25 11:06:32.907372114 +0000
> @@ -80,17 +80,18 @@
>      . = ALIGN(PAGE_SIZE);    /* keep ZO size page aligned */
>      _end = .;
> 
> -    STABS_DEBUG
> -    DWARF_DEBUG
> -    ELF_DETAILS
> -
>      DISCARDS
>      /DISCARD/ : {
>          *(.dynamic) *(.dynsym) *(.dynstr) *(.dynbss)
>          *(.hash) *(.gnu.hash)
>          *(.note.*)
> +        *(.modinfo)
>      }
> 
> +    STABS_DEBUG
> +    DWARF_DEBUG
> +    ELF_DETAILS
> +
>      .got.plt (INFO) : {
>          *(.got.plt)
>      }
> 
> 
> Thanks for isolating the issue!

Thanks again for reporting it and sorry that I missed it.

Cheers,
Nathan

      reply	other threads:[~2026-02-25 21:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <587f25e0-a80e-46a5-9f01-87cb40cfa377@wildgooses.com>
2026-02-24 12:11 ` extlinux can't boot kernel after commit "kbuild: keep .modinfo section in vmlinux.unstripped" Thorsten Leemhuis
2026-02-24 20:46   ` Nathan Chancellor
2026-02-25 11:55     ` Ed W
2026-02-25 21:24       ` Nathan Chancellor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260225212425.GH2755225@ax162 \
    --to=nathan@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lists@wildgooses.com \
    --cc=masahiroy@kernel.org \
    --cc=nsc@kernel.org \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox