From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2AD963BF675; Tue, 10 Mar 2026 16:06:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773158802; cv=none; b=ulVeHXy68WUiBMm9grCCOrEKEByqFzoYrWJ3xyLJ6qB28mCbw4N607qMFOUr2rVkK8CT9WctWLF8Ie614vT/B99h209SeV3gNctqUNLISd5en2A4nLU/HRyiHOGpdA3Ue+QQz1vzHwGrRCEUP76t1+zPSRyHbYJKuBcz3ovuVxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773158802; c=relaxed/simple; bh=pFTE7f4sOuYyaW3cEsKIhXjgl8+epJV62o4SfIfOkEU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u4sWZa6C63fhcUkoZsdTv0Zb9CUAYytQbjzA4ZUZklxuDCIppLBeRjwCOjUKLAaxE1L2j4BaM4uZVoijrLcDQKAu5CAXJPyRB1Ztyq8RAy1S11Yhpty1NDApEQfEi4ESuF/uLInCCITIh7tAeAg74MvMD007Vn7Xws9fHSULxPI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 499781596; Tue, 10 Mar 2026 09:06:34 -0700 (PDT) Received: from localhost (e132581.arm.com [10.1.196.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E69A3F73B; Tue, 10 Mar 2026 09:06:40 -0700 (PDT) Date: Tue, 10 Mar 2026 16:06:38 +0000 From: Leo Yan To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Arnaldo Carvalho de Melo , Ian Rogers , Namhyung Kim , James Clark , Kees Cook , Quentin Monnet , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Adrian Hunter , Masami Hiramatsu , William Breathitt Gray , Barry Song , Qinxin Xia , Bartosz Golaszewski , Kent Gibson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Andrew Morton , Willy Tarreau , Josh Poimboeuf , Robert Moore , Len Brown , Srinivas Pandruvada , Tejun Heo , David Vernet , Andrea Righi , Changwoo Min , Mark Brown , Steven Rostedt , Gabriele Monaco , Shuah Khan , Jiri Kosina , Benjamin Tissoires , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH v3 29/30] selftests/nolibc: Append extra cflags Message-ID: <20260310160638.GD4153946@e132581.arm.com> References: <20260308-tools_build_fix_zero_init-v3-0-6477808123b7@arm.com> <20260308-tools_build_fix_zero_init-v3-29-6477808123b7@arm.com> Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Mar 09, 2026 at 11:24:58PM +0100, Thomas Weißschuh wrote: > Hi Leo, > > On 2026-03-08 16:46:34+0000, Leo Yan wrote: > > Append EXTRA_CFLAGS to CFLAGS so that additional flags can be applied to > > the compiler. > > > > Signed-off-by: Leo Yan > > --- > > tools/testing/selftests/nolibc/Makefile.nolibc | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/tools/testing/selftests/nolibc/Makefile.nolibc b/tools/testing/selftests/nolibc/Makefile.nolibc > > index f5704193038f7da935d57e0f894970b6e29b78da..e58b2f5eb2b231bb1c194db7365fff7b4e244e5d 100644 > > --- a/tools/testing/selftests/nolibc/Makefile.nolibc > > +++ b/tools/testing/selftests/nolibc/Makefile.nolibc > > @@ -252,6 +252,9 @@ endif > > # Modify CFLAGS based on LLVM= > > include $(srctree)/tools/scripts/Makefile.include > > > > +# Append EXTRA_CFLAGS if it is set in tools/scripts/Makefile.include > > +CFLAGS += $(EXTRA_CFLAGS) > > Makefile.nolibc here is completely self-contained. It is not expected to > inherit any flags from the regular selftests. So I don't think this makes > sense. There is a similar, custom "CFLAGS_EXTRA" variable, which could > be aligned, but probably not as part of this series. > > There is a regular 'Makefile' in this directory which *is* integrated > with the regular selftest build system. If you could make sure that > it works correctly with what you are doing, that would be great. Sure, I will update the regular Makefile. As you suggested, I also will drop patch 18 in new version. Thanks for suggestions!