From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A58633FE0A for ; Fri, 15 May 2026 19:53:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778874824; cv=none; b=fenxJa7HxbanBkztlGG7ztdlFTDD//CSrvit03N9Pww1iOw7NvhCYZDAAxyaAwnLZ3n9AOSpp3KT5SjrCKeEyKOm4GPHTt3OmKM/0cvT2uvmusXCtnZpuyHf+W4qY03Qx17Ky/BxL17dM7D/3t9CNI4OBNl0fVbK9PHbJ15UeyY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778874824; c=relaxed/simple; bh=Odo0yKm+gdJpAQcxTdFkFl8NtkkE0Q/HFOlz98xNH/Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OsuwMqEFOA4Q97YOu6LaIlVhx6lOzWY67tpbZsaCevuQWV0wwL6+DGomMwm6WEwbetrmnjaxKlN4tucUqjFVZF1hmYXe8v23xuHW3BZuIRYRqTkfIjwHSoLd34NXHCqC7bl6JmFeOzIXRLB+ORZI8aNIcPbWewnr+0n5D0INBlg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ie14WCqZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ie14WCqZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 943DDC2BCB0; Fri, 15 May 2026 19:53:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778874823; bh=Odo0yKm+gdJpAQcxTdFkFl8NtkkE0Q/HFOlz98xNH/Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ie14WCqZccKW3GRxjHFWMGNtU9Yp2yIT74YA367uQP5wJmtAbU2kJyX7KH3S9gApO ZICq6sqGOxLqJPSk5pacGL86EcnFEFjxWp6IbXGF1HbW+l0G4EBLV4086i+GgA+uNf uGalQPgXG6egd1l/dQow1LBRRWEO5aIma5NMrT5+hvZqSobjhD9wvH0UtFlJNX6Xxn lRmHbz34EJ9uPCXONiywqd3O2n0RK8HYvRp517d5QnOGseJ3ZPHuGNa+9O3C/7d3FS uLmhqy5DRZmZS8V5KGqiAuUDeDkfuFLa5uRx5LqOiA1wWLSWBjjRp8OfCrzICRBQcP IQdmG+n9iRjpQ== Date: Sat, 16 May 2026 04:53:39 +0900 From: Nathan Chancellor To: Nicolas Schier Cc: Jill Ravaliya , masahiroy@kernel.org, linux-kbuild@vger.kernel.org Subject: Re: [PATCH] kbuild: deb-pkg: propagate hook script failures in builddeb Message-ID: <20260515195339.GA553537@ax162> References: <20260501012018.43278-1-jillravaliya@gmail.com> Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, May 15, 2026 at 09:30:21PM +0200, Nicolas Schier wrote: > On Fri, May 01, 2026 at 06:50:18AM +0530, Jill Ravaliya wrote: > > The 'builddeb' script generates maintainer scripts for Debian-based > > distributions. Currently, it invokes post-installation hooks via > > run-parts but unconditionally exits with code 0. > > Are you sure? On my Debian trixie, run-parts exits with 1 as soon as a > single script from the given directory exists with non-zero. ... > > This patch ensures that failures in 'run-parts' are correctly > > propagated, allowing the package manager to abort the installation > > upon hook failure. Hmmm, yeah, I had missed the 'set -e' in this script, so I think this change should be unnecessary because run-parts failures should already be propagated up from 'set -e'. If a script in /{etc,usr/share}/kernel does not error when it should, there is nothing we can do about that (which appears to be the cause of the original issue). Thanks for the review! -- Cheers, Nathan