From: Nathan Chancellor <nathan@kernel.org>
To: "Viktor Jägersküpper" <viktor_jaegerskuepper@freenet.de>,
"Nicolas Schier" <nsc@kernel.org>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
"Christian Heusel" <christian@heusel.eu>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kbuild: pacman-pkg: make "rc" releases adhere to pacman versioning scheme
Date: Sun, 17 May 2026 19:24:15 +0900 [thread overview]
Message-ID: <20260517102415.GA1866872@ax162> (raw)
In-Reply-To: <20260515215913.92481-1-viktor_jaegerskuepper@freenet.de>
On Fri, May 15, 2026 at 11:58:45PM +0200, Viktor Jägersküpper wrote:
> The package versioning scheme does not enable smooth upgrades from "rc"
> releases to the corresponding stable releases (e.g. 7.0.0-rc7 -> 7.0.0)
> because pacman considers that a downgrade due to the underscore in
> pkgver (e.g. 7.0.0_rc7), see e.g. vercmp(8) for an explanation of the
> package version comparison used by pacman. Package versions which are
> derived from said releases (e.g. built from git revisions) are
> similarly affected. Fix this by modifying pkgver in order to remove the
> hyphen from kernel versions containing "-rcN", where N is a
> non-negative integer.
>
> Acked-by: Thomas Weißschuh <linux@weissschuh.net>
> Signed-off-by: Viktor Jägersküpper <viktor_jaegerskuepper@freenet.de>
Nicolas, do you want to take this as a fix for 7.1 (since it seems
reasonable to correct this for folks building from upstreaam sooner
rather than later)? If so:
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Otherwise, I can pick it up for 7.2 when I am fully back online in a
couple of days.
> ---
> v1 -> v2:
> - make the substitution more restrictive
> - enhance commit message accordingly
> - add Acked-by tag
>
> v1: https://lore.kernel.org/linux-kbuild/20260513231745.51780-1-viktor_jaegerskuepper@freenet.de/
>
> BTW this also works for something like "5.10.248-rt143-rc1" which is a
> recent example of an "rc" release of a realtime kernel.
>
> scripts/package/PKGBUILD | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/package/PKGBUILD b/scripts/package/PKGBUILD
> index 452374d63c24..1213c8e04671 100644
> --- a/scripts/package/PKGBUILD
> +++ b/scripts/package/PKGBUILD
> @@ -10,7 +10,7 @@ for pkg in $_extrapackages; do
> pkgname+=("${pkgbase}-${pkg}")
> done
>
> -pkgver="${KERNELRELEASE//-/_}"
> +pkgver="$(echo "${KERNELRELEASE}" | sed 's/-\(rc[0-9]\+\)/\1/;s/-/_/g')"
> # The PKGBUILD is evaluated multiple times.
> # Running scripts/build-version from here would introduce inconsistencies.
> pkgrel="${KBUILD_REVISION}"
>
> ---
> base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
>
> Best regards,
> Viktor
> --
> 2.54.0
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-05-17 10:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 21:58 [PATCH v2] kbuild: pacman-pkg: make "rc" releases adhere to pacman versioning scheme Viktor Jägersküpper
2026-05-16 14:27 ` Viktor Jägersküpper
2026-05-16 15:33 ` Nathan Chancellor
2026-05-17 0:57 ` Viktor Jägersküpper
2026-05-17 5:00 ` Nathan Chancellor
2026-05-17 9:41 ` Thomas Weißschuh
2026-05-17 10:24 ` Nathan Chancellor [this message]
2026-05-17 19:31 ` Nicolas Schier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260517102415.GA1866872@ax162 \
--to=nathan@kernel.org \
--cc=christian@heusel.eu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=nsc@kernel.org \
--cc=viktor_jaegerskuepper@freenet.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox