From: Nathan Chancellor <nathan@kernel.org>
To: Zhou Yuhang <zhouyuhang1010@163.com>
Cc: nsc@kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, Zhou Yuhang <zhouyuhang@kylinos.cn>
Subject: Re: [PATCH] kconfig: Fix repeated include selftest expectation
Date: Wed, 20 May 2026 15:43:08 -0700 [thread overview]
Message-ID: <20260520224308.GD1607511@ax162> (raw)
In-Reply-To: <20260520070800.2265479-1-zhouyuhang1010@163.com>
On Wed, May 20, 2026 at 03:08:00PM +0800, Zhou Yuhang wrote:
> From: Zhou Yuhang <zhouyuhang@kylinos.cn>
>
> The err_repeated_inc test was added with an expected stderr fixture
> that does not match the diagnostic printed by kconfig.
>
> Running "make testconfig" currently fails in that test even though the
> parser reports the duplicated include correctly:
>
> [stderr]
> Kconfig.inc1:4: error: repeated inclusion of Kconfig.inc3
> Kconfig.inc2:3: note: location of first inclusion of Kconfig.inc3
>
> The fixture expects "Repeated" and "Location" with capital letters, but
> the diagnostic emitted by scripts/kconfig/util.c uses lowercase words.
> Update the fixture to match the real message.
>
> Fixes: 102d712ded3e ("kconfig: Error out on duplicated kconfig inclusion")
> Signed-off-by: Zhou Yuhang <zhouyuhang@kylinos.cn>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> scripts/kconfig/tests/err_repeated_inc/expected_stderr | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kconfig/tests/err_repeated_inc/expected_stderr b/scripts/kconfig/tests/err_repeated_inc/expected_stderr
> index 95d90d6a93c5..53071430ea7d 100644
> --- a/scripts/kconfig/tests/err_repeated_inc/expected_stderr
> +++ b/scripts/kconfig/tests/err_repeated_inc/expected_stderr
> @@ -1,2 +1,2 @@
> -Kconfig.inc1:4: error: Repeated inclusion of Kconfig.inc3
> -Kconfig.inc2:3: note: Location of first inclusion of Kconfig.inc3
> +Kconfig.inc1:4: error: repeated inclusion of Kconfig.inc3
> +Kconfig.inc2:3: note: location of first inclusion of Kconfig.inc3
> --
> 2.43.0
>
--
Cheers,
Nathan
prev parent reply other threads:[~2026-05-20 22:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 7:08 [PATCH] kconfig: Fix repeated include selftest expectation Zhou Yuhang
2026-05-20 13:24 ` Nicolas Schier
2026-05-20 22:43 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520224308.GD1607511@ax162 \
--to=nathan@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsc@kernel.org \
--cc=zhouyuhang1010@163.com \
--cc=zhouyuhang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox