From: Sam Ravnborg <sam@ravnborg.org>
To: Julian Braha <julianbraha@gmail.com>
Cc: nathan@kernel.org, nsc@kernel.org, rdunlap@infradead.org,
masahiroy@kernel.org, grahamr@qti.qualcomm.com, nico@fluxnic.net,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kconfig: warn on dead default
Date: Sat, 6 Jun 2026 19:36:13 +0200 [thread overview]
Message-ID: <20260606173613.GA126491@ravnborg.org> (raw)
In-Reply-To: <a5d09cc6-2878-443f-899d-dafb286322ad@gmail.com>
Hi Julian.
On Sat, Jun 06, 2026 at 04:01:34PM +0100, Julian Braha wrote:
> On 6/6/26 15:23, Sam Ravnborg wrote:
> > I looks redundant with the two loops were we for the latter knows it is
> > a P_DEFAULT.
>
> Hi Sam,
>
> It may look redundant, but we do need to check each default we encounter
> in the
> ```
> for (prop = sym->prop; prop; prop = prop->next) {
> ```
> loop against the previous defaults to know if we've encountered a
> duplicate default condition.
>
> I guess the other approach would be to copy each default as we encounter
> them into a hashtable and check against that, instead? Let me know if
> you have another, preferred approach.
It was just a drive-by comment, keep it as simple as possible.
Sam
prev parent reply other threads:[~2026-06-06 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-06 14:00 [PATCH] kconfig: warn on dead default Julian Braha
2026-06-06 14:23 ` Sam Ravnborg
2026-06-06 15:01 ` Julian Braha
2026-06-06 17:36 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260606173613.GA126491@ravnborg.org \
--to=sam@ravnborg.org \
--cc=grahamr@qti.qualcomm.com \
--cc=julianbraha@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nico@fluxnic.net \
--cc=nsc@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox