From: Nathan Chancellor <nathan@kernel.org>
To: omer zalman <omerzalman42@gmail.com>
Cc: nsc@kernel.org, llvm@lists.linux.dev,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts: run-clang-tools: import os for broken pipe handling
Date: Tue, 29 Sep 2026 22:23:19 +0200 [thread overview]
Message-ID: <20260929202319.GB3237201@ax162> (raw)
In-Reply-To: <CAGLNFZeLTDhLj5bzOVC51J6Az6E1D9PWj6yzgHZO8Rg-82kpHw@mail.gmail.com>
Hi Omer,
On Mon, Sep 28, 2026 at 07:47:14PM -0400, omer zalman wrote:
> The BrokenPipeError handler calls os.open() and os.dup2(), but the
> module never imports os. A broken output pipe therefore raises
> NameError while handling the original error. Import os so the
> handler can redirect stdout and exit as intended.
>
> Signed-off-by: Omer Zalman <omerzalman42@gmail.com>
>
> The exact git-format-patch file is attached because Gmail's web
> composer removes tabs from inline diffs.
As folks have mentioned on your other patches, you need to send your
patch using either git send-email or b4 so that they can be properly
handled by our tools, an attachment will not cut it.
Additionally, was this change inspired or developed by an LLM/agent? I
only ask because this has been broken for ages and you and another
person sent basically the same patch within a week of each other.
https://lore.kernel.org/179017337986.52388.7943687183785012868@gmail.com/
Odd coincidence if not. If so, please follow our coding assistants
documentation:
https://docs.kernel.org/process/coding-assistants.html
--
Cheers,
Nathan
prev parent reply other threads:[~2026-09-29 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 23:47 [PATCH] scripts: run-clang-tools: import os for broken pipe handling omer zalman
2026-09-29 20:23 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929202319.GB3237201@ax162 \
--to=nathan@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nsc@kernel.org \
--cc=omerzalman42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox