From: Nathan Chancellor <nathan@kernel.org>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Nicolas Schier <nsc@kernel.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Nam Cao <namcao@linutronix.de>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH RFC] kbuild: enable pipefail for commands where possible
Date: Thu, 15 Oct 2026 18:10:56 -0700 [thread overview]
Message-ID: <20261016011056.GB3329673@ax162> (raw)
In-Reply-To: <20261015121210-dbee14b9-538f-4069-8934-153456b3ccd3@linutronix.de>
On Thu, Oct 15, 2026 at 12:15:18PM +0200, Thomas Weißschuh wrote:
> It actually breaks modversions quite badly. And it is not obvious to debug
Welp, good to know I wasn't very far off with that review comment :)
> as that uses the pipe in an `if` statement which swallows the 141 silently.
Ah yeah, great point.
> Not sure what to do here.
>
> Maybe we just provide `try-pipefail` so users can opt-in where it makes sense.
Yeah, that seems like a much more reasonable starting point, as
something like this should likely be considered on a case-by-case basis
anyways.
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-10-16 1:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 8:30 [PATCH RFC] kbuild: enable pipefail for commands where possible Thomas Weißschuh
2026-10-14 21:40 ` Nathan Chancellor
2026-10-15 10:15 ` Thomas Weißschuh
2026-10-16 1:10 ` Nathan Chancellor [this message]
2026-10-15 8:36 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016011056.GB3329673@ax162 \
--to=nathan@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=namcao@linutronix.de \
--cc=nsc@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox