From: Nathan Chancellor <nathan@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: vngocvan <vngocvan@gmail.com>,
nsc@kernel.org, morbo@google.com, justinstitt@google.com,
masahiroy@kernel.org, llvm@lists.linux.dev,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gen_compile_commands: honor the build directory for modules
Date: Thu, 15 Oct 2026 18:12:24 -0700 [thread overview]
Message-ID: <20261016011224.GC3329673@ax162> (raw)
In-Reply-To: <CAKwvOdnkS7AnuJkQr=5-TO6eRL+joSNUKGfqK-mbim9_y0NW=A@mail.gmail.com>
On Thu, Oct 15, 2026 at 08:33:11AM -0700, Nick Desaulniers wrote:
> Thanks for the patch. Can we avoid os.path in favor of Path from
> Pathlib? Here and throughout.
I would not mind seeing some modernization in this script such as
os.path -> pathlib.Path but it should definitely be done as a separate
patch.
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-10-16 1:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 13:57 [PATCH] gen_compile_commands: honor the build directory for modules vngocvan
2026-10-15 15:33 ` Nick Desaulniers
2026-10-16 1:12 ` Nathan Chancellor [this message]
2026-10-16 1:21 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016011224.GC3329673@ax162 \
--to=nathan@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
--cc=nsc@kernel.org \
--cc=vngocvan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox