From: Sasha Levin <sashal@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: linux-kbuild@vger.kernel.org, linux-modules@vger.kernel.org
Subject: Re: [PATCH v10 1/4] kallsyms: embed source file:line info in kernel stack traces
Date: Thu, 5 Nov 2026 15:18:32 -0500 [thread overview]
Message-ID: <20261105201832.3238538-1-sashal@kernel.org> (raw)
In-Reply-To: <sashiko-outbox-195130@kernel.org>
On Tue, Nov 03, 2026 at 11:15:24AM +0000, sashiko-bot@kernel.org wrote:
[...]
>In elfutils, libdw.pc lists libelf under Requires.private rather than
>Requires.
It's under Requires, so pkg-config prints "-ldw -lelf".
[...]
>Can unfiltered ELF symbols in collect_symbol_starts() in
>scripts/gen_lineinfo.c corrupt the symbol extents in text_starts[]?
No. Filtering them changes nothing on x86, arm64, riscv or powerpc. On
arm it drops three $a symbols that start line-program sequences with no
named symbol, and those addresses lose their annotation.
[...]
>Additionally, why does collect_symbol_starts() exclude STT_NOTYPE and
>unsized symbols from sym_starts[]?
Without a size there is no way to check that a covering row belongs to
the symbol. Untyped labels that start code are almost all in assembly,
which gets a row per instruction anyway.
--
Thanks,
Sasha
next prev parent reply other threads:[~2026-11-05 20:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 11:14 [PATCH v10 0/4] kallsyms: embed source file:line info in kernel stack traces Sasha Levin
2026-11-02 11:14 ` [PATCH v10 1/4] " Sasha Levin
2026-11-03 11:15 ` sashiko-bot
2026-11-05 20:18 ` Sasha Levin [this message]
2026-11-02 11:14 ` [PATCH v10 2/4] kallsyms: extend lineinfo to loadable modules Sasha Levin
2026-11-03 11:15 ` sashiko-bot
2026-11-02 11:14 ` [PATCH v10 3/4] kallsyms: delta-compress lineinfo tables for ~2.7x size reduction Sasha Levin
2026-11-02 11:14 ` [PATCH v10 4/4] kallsyms: add KUnit tests for lineinfo feature Sasha Levin
2026-11-03 11:15 ` sashiko-bot
2026-11-05 20:18 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105201832.3238538-1-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox