From: David Laight <david.laight.linux@gmail.com>
To: sashiko-bot@kernel.org
Cc: sashiko-reviews@lists.linux.dev, "Petr Mladek" <pmladek@suse.com>,
"Kees Cook" <kees@kernel.org>,
linux-kbuild@vger.kernel.org, bpf@vger.kernel.org,
"Jim Cromie" <jim.cromie@gmail.com>,
"Lorenzo Stoakes" <ljs@kernel.org>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Andrey Grodzovsky" <andrey.grodzovsky@crowdstrike.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Samuel Wu" <wusamuel@google.com>,
nathan@kernel.org, nsc@kernel.org
Subject: Re: [PATCH v4 next 05/13] kallsyms: Fix selftest startup delay
Date: Tue, 17 Nov 2026 11:06:55 +0000 [thread overview]
Message-ID: <20261117110655.1294a95f@pumpkin> (raw)
In-Reply-To: <sashiko-outbox-218653@kernel.org>
On Tue, 17 Nov 2026 10:40:36 +0000
sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] kallsyms: missing Fixes trailer for schedule_timeout() bug in
> test_entry()
> --
>
> commit e7ea6257d7756e16690d0150d840ede1f6384772
> Author: David Laight <david.laight.linux@gmail.com>
>
> > kallsyms: Fix selftest startup delay
> >
> > The kallsym_selftest code clearly intends to sleep until initialisation
> > is complete in order to get more reproducable timings.
> >
> > Replace the schedule_timeout() calls with schedule_timeout_idle()
> > so that the thread actually sleeps.
> > Poll every second (not every 5) for SYSTEM_RUNNING and then wait
> > another 10 seconds before starting the tests, otherwise the tests
> > start as soon an init is executed.
> >
> > This code is in the initial 2022 import of the tests.
> >
> > Signed-off-by: David Laight <david.laight.linux@gmail.com>
>
> [Severity: Low]
> Since this fixes test_entry() calling schedule_timeout() in TASK_RUNNING
> state and busy-looping instead of sleeping, should this include:
>
> Fixes: 30f3bb09778d ("kallsyms: Add self-test facility")
>
No, selftest, doesn't need back porting.
(Did I say that before?)
David
next prev parent reply other threads:[~2026-11-17 11:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 10:33 [PATCH v4 next 00/13] kallsyms: optimise symbol search by name David Laight
2026-11-17 10:33 ` [PATCH v4 next 01/13] scripts/kallsyms: Avoid overrunning on-stack buffer David Laight
2026-11-17 10:33 ` [PATCH v4 next 02/13] scripts/kallsyms: Improve error reporting David Laight
2026-11-17 10:33 ` [PATCH v4 next 03/13] scripts/elf-parse: add elf_map_big_endian() helper David Laight
2026-11-17 10:33 ` [PATCH v4 next 04/13] scripts/kallsyms: make use of binary data output optional David Laight
2026-11-17 10:33 ` [PATCH v4 next 05/13] kallsyms: Fix selftest startup delay David Laight
2026-11-17 10:40 ` sashiko-bot
2026-11-17 11:06 ` David Laight [this message]
2026-11-17 10:33 ` [PATCH v4 next 06/13] kallsyms: Improve selftest test_perf_kallsyms_lookup_name() output David Laight
2026-11-17 10:33 ` [PATCH v4 next 07/13] kallsyms: Match compressed tokens on the fly during binary search David Laight
2026-11-17 10:33 ` [PATCH v4 next 08/13] kallsyms: Optimise symbol name search David Laight
2026-11-17 10:33 ` [PATCH v4 next 09/13] kallsyms: Add a kernel parameter to change the kallsyms_markers[] density David Laight
2026-11-17 10:33 ` [PATCH v4 next 10/13] scripts/kallsyms: Keep full expansion of tokens David Laight
2026-11-17 10:33 ` [PATCH v4 next 11/13] scripts/kallsyms: Optimise compress_symbols() David Laight
2026-11-17 10:33 ` [PATCH v4 next 12/13] scripts/kallsyms: Reuse tokens that have no references David Laight
2026-11-17 10:33 ` [PATCH v4 next 13/13] scripts/kallsyms: Reuse little-used compression tokens David Laight
2026-11-17 10:57 ` sashiko-bot
2026-11-17 11:06 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117110655.1294a95f@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=andrey.grodzovsky@crowdstrike.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=jim.cromie@gmail.com \
--cc=kees@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=mcgrof@kernel.org \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wusamuel@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox