Re: [PATCH 1/4] kconfig: add short explanation to SYMBOL_WRITE

Martin Walch
2013-10-03T00:26:54Z

On Wednesday 02 October 2013 16:42:27 David Rientjes wrote:
> The purpose of SYMBOL_WRITE is in sym_calc_value() where it is set if the
> config symbol is visible and settable by the user, which is why I
> suggested it be specified as being writable by the user.

Then this looks strange to me: a config symbol of type boolean or tristate
that is not visible, but has a default value != n will have SYMBOL_WRITE set
in sym_calc_value:

> case S_BOOLEAN:
> case S_TRISTATE:
> if (sym_is_choice_value(sym) && sym->visible == yes) {
> ...
> } else {
> ...
> if (!sym_is_choice(sym)) {
> prop = sym_get_default_prop(sym);
> if (prop) {
> sym->flags |= SYMBOL_WRITE;
> newval.tri = EXPR_AND(expr_calc_value(prop->expr),
> prop->visible.tri);
> }
> }
> ...
> }
--